From 4ba1877e9867ccc41e6f4443efa5c1adf3cf24b2 Mon Sep 17 00:00:00 2001
From: Neil Williams <neil@reddit.com>
Date: Fri, 19 Aug 2011 10:09:53 -0700
Subject: [PATCH] Properly escape url parameter in click tracking.

---
 r2/r2/lib/tracking.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/r2/r2/lib/tracking.py b/r2/r2/lib/tracking.py
index b47100e31..4618ad7da 100644
--- a/r2/r2/lib/tracking.py
+++ b/r2/r2/lib/tracking.py
@@ -27,6 +27,7 @@ from random import choice
 from pylons import g, c
 from urllib import quote_plus, unquote_plus
 import sha
+import urllib
 
 key_len = 16
 pad_len = 32
@@ -198,7 +199,8 @@ class PromotedLinkClickInfo(PromotedLinkInfo):
         return PromotedLinkInfo.init_defaults(self, **kw)
 
     def tracking_url(self):
-        s = (PromotedLinkInfo.tracking_url(self) + '&url=' + self.dest)
+        s = (PromotedLinkInfo.tracking_url(self) + '&url=' +
+             urllib.quote_plus(self.dest))
         return s
 
 class AdframeInfo(PromotedLinkInfo):