From 578dc7a2c55ff07b0827a0485594bdf06fc95bbb Mon Sep 17 00:00:00 2001 From: Neil Williams Date: Wed, 11 Jan 2012 21:06:45 -0800 Subject: [PATCH] Revert "Clean up usage_q infrastructure." --- r2/r2/controllers/reddit_base.py | 17 ++++++++--------- r2/r2/lib/queues.py | 7 +------ r2/r2/models/admintools.py | 3 +++ 3 files changed, 12 insertions(+), 15 deletions(-) diff --git a/r2/r2/controllers/reddit_base.py b/r2/r2/controllers/reddit_base.py index c6f4f18ef..7a6ddc447 100644 --- a/r2/r2/controllers/reddit_base.py +++ b/r2/r2/controllers/reddit_base.py @@ -644,15 +644,14 @@ class MinimalController(BaseController): log_text("unknown action", "no action for %r" % path_info, "warning") if g.usage_sampling >= 1.0 or rand.random() < g.usage_sampling: - amqp.add_kw( - "request_info", - ip=request.ip, - start_time=c.start_time, - end_time=end_time, - sampling_rate=g.usage_sampling, - action=action, - headers=dict(request.headers) - ) + + amqp.add_kw("usage_q", + start_time = c.start_time, + end_time = end_time, + sampling_rate = g.usage_sampling, + action = action) + + check_request(end_time) # this thread is probably going to be reused, but it could be # a while before it is. So we might as well dump the cache in diff --git a/r2/r2/lib/queues.py b/r2/r2/lib/queues.py index 9be0e4335..b88c7b2b9 100644 --- a/r2/r2/lib/queues.py +++ b/r2/r2/lib/queues.py @@ -73,19 +73,17 @@ class RedditQueueMap(QueueMap): self._q('vote_link_q', self_refer=True) self._q('vote_comment_q', self_refer=True) self._q('log_q', self_refer=True) + self._q('usage_q', self_refer=True, durable=False) self._q('solrsearch_changes') self._q('indextank_changes', self_refer=True) self._bind('search_changes', 'solrsearch_changes') self._bind('search_changes', 'indextank_changes') - self._q('usage_q', durable=False) - def bindings(self): self.newlink_bindings() self.newcomment_bindings() self.newsubreddit_bindings() - self.requestinfo_bindings() def newlink_bindings(self): self._bind('new_link', 'scraper_q') @@ -100,9 +98,6 @@ class RedditQueueMap(QueueMap): def newsubreddit_bindings(self): pass - def requestinfo_bindings(self): - self._bind('request_info', 'usage_q') - try: from r2admin.lib.adminqueues import * except ImportError: diff --git a/r2/r2/models/admintools.py b/r2/r2/models/admintools.py index 1cf2b31c1..6c94d8c32 100644 --- a/r2/r2/models/admintools.py +++ b/r2/r2/models/admintools.py @@ -399,6 +399,9 @@ def filter_quotas(unfiltered): else: return baskets, None +def check_request(end_time): + pass + try: from r2admin.models.admintools import * except ImportError: