From 633ed54a2d727ebd3c5e4cc7136c1e61a1ec0f6d Mon Sep 17 00:00:00 2001 From: Brian Simpson Date: Thu, 31 Oct 2013 18:08:26 -0400 Subject: [PATCH] Campaign 'override' attribute can't be boolean. --- r2/r2/lib/promote.py | 3 ++- r2/r2/public/static/js/sponsored.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/r2/r2/lib/promote.py b/r2/r2/lib/promote.py index 5200fc45a..e5dad72b5 100644 --- a/r2/r2/lib/promote.py +++ b/r2/r2/lib/promote.py @@ -202,7 +202,8 @@ class RenderableCampaign(): self.cpm = cpm self.sr = sr self.priority_name = priority.name - self.inventory_override = priority.inventory_override + self.inventory_override = ("override" if priority.inventory_override + else "") self.status = status @classmethod diff --git a/r2/r2/public/static/js/sponsored.js b/r2/r2/public/static/js/sponsored.js index d19e0ad5e..d5ba1bd1f 100644 --- a/r2/r2/public/static/js/sponsored.js +++ b/r2/r2/public/static/js/sponsored.js @@ -83,7 +83,7 @@ r.sponsored = { return {} } - var existingOverride = campaign_row.find('*[name="override"]').val() + var existingOverride = campaign_row.find('*[name="override"]').val() == "override" if (isOverride != existingOverride) { return {} }