From 94abab2c45cb87e9361b06148092f0fc4d8ce822 Mon Sep 17 00:00:00 2001 From: Jason Harvey Date: Thu, 28 Feb 2013 13:10:52 -0800 Subject: [PATCH] Ensure checkboxes and radios don't set form fields when unchecked. --- r2/r2/public/static/js/reddit.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/r2/r2/public/static/js/reddit.js b/r2/r2/public/static/js/reddit.js index 574e6aec7..978490436 100644 --- a/r2/r2/public/static/js/reddit.js +++ b/r2/r2/public/static/js/reddit.js @@ -91,11 +91,10 @@ function get_form_fields(form, fields, filter_func) { return; } if ($el.data('send-checked')) { - val = $el.is(':checked'); + fields[$el.attr("name")] = $el.is(':checked'); } else if ((type != "radio" && type != "checkbox") || $el.is(":checked")) { - val = $el.val(); + fields[$el.attr("name")] = $el.val(); } - fields[$el.attr("name")] = val; }); if (fields.id == null) { fields.id = $(form).attr("id") ? ("#" + $(form).attr("id")) : "";