From b840c6e1978ac3e5ab663cb0e843e0bc1b4c525f Mon Sep 17 00:00:00 2001
From: umbrae <umbrae@reddit.com>
Date: Sat, 31 May 2014 05:51:14 -0700
Subject: [PATCH] Make time_listings defensive against bad URLs

---
 r2/r2/lib/mr_top.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/r2/r2/lib/mr_top.py b/r2/r2/lib/mr_top.py
index 846bfc237..ec659a5e8 100644
--- a/r2/r2/lib/mr_top.py
+++ b/r2/r2/lib/mr_top.py
@@ -82,7 +82,12 @@ def time_listings(intervals):
                        thing_controversy, thing.timestamp, fname)
 
                 if thing.url:
-                    for domain in UrlParser(thing.url).domain_permutations():
+                    try:
+                        parsed = UrlParser(thing.url)
+                    except ValueError:
+                        continue
+
+                    for domain in parsed.domain_permutations():
                         yield ("domain/link/top/%s/%s" % (interval, domain),
                                thing_score, thing.timestamp, fname)
                         yield ("domain/link/controversial/%s/%s" % (interval, domain),