From bb5a6f11008b8e4fd99b283dc040640a53043940 Mon Sep 17 00:00:00 2001 From: Max Goodman Date: Fri, 12 Apr 2013 14:41:07 -0700 Subject: [PATCH] bubble: Stop appending to parent element when hidden. This avoids unintentional styling of bubble content within the parent element when it is supposed to be hidden. --- r2/r2/public/static/js/multi.js | 1 - r2/r2/public/static/js/ui.js | 1 - 2 files changed, 2 deletions(-) diff --git a/r2/r2/public/static/js/multi.js b/r2/r2/public/static/js/multi.js index 4dba5c4de..ca65f0dc5 100644 --- a/r2/r2/public/static/js/multi.js +++ b/r2/r2/public/static/js/multi.js @@ -161,7 +161,6 @@ r.multi.SubscribeButton = Backbone.View.extend({ group: this.options.bubbleGroup, sr_name: this.$el.data('sr_name') }) - this.$el.append(this.bubble.el) } }) diff --git a/r2/r2/public/static/js/ui.js b/r2/r2/public/static/js/ui.js index edada1f0b..4b8e4234f 100644 --- a/r2/r2/public/static/js/ui.js +++ b/r2/r2/public/static/js/ui.js @@ -229,7 +229,6 @@ r.ui.Bubble = Backbone.View.extend({ this.options.group.current = null } this.$el.hide() - this.$parent.append(this.$el) }, hide: function(callback) {