From cfc462b5f66a466ea0f407cf1754b468858d83de Mon Sep 17 00:00:00 2001 From: Neil Williams Date: Thu, 16 Jan 2014 12:34:34 -0800 Subject: [PATCH] Pass return values on from {add,remove}_moderator. This was causing modship PMs not to be sent. --- r2/r2/models/subreddit.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/r2/r2/models/subreddit.py b/r2/r2/models/subreddit.py index 361614173..8c7d9dad4 100644 --- a/r2/r2/models/subreddit.py +++ b/r2/r2/models/subreddit.py @@ -331,16 +331,18 @@ class Subreddit(Thing, Printable, BaseSite): if not user.modmsgtime: user.modmsgtime = False user._commit() - super(Subreddit, self).add_moderator(user, **kwargs) + return super(Subreddit, self).add_moderator(user, **kwargs) def remove_moderator(self, user, **kwargs): - super(Subreddit, self).remove_moderator(user, **kwargs) + ret = super(Subreddit, self).remove_moderator(user, **kwargs) is_mod_somewhere = bool(Subreddit.reverse_moderator_ids(user)) if not is_mod_somewhere: user.modmsgtime = None user._commit() + return ret + @property def moderators(self): return self.moderator_ids()