From d964c2fa7e2087100af9e8fe337abe6736a61ba1 Mon Sep 17 00:00:00 2001
From: spez <steve@reddit.com>
Date: Mon, 22 Jun 2009 15:50:25 -0700
Subject: [PATCH] fix some tabbing issue in IE forms. align the sr dropdown
 properly in IE

---
 r2/r2/public/static/css/reddit.css |  1 +
 r2/r2/public/static/js/reddit.js   |  3 +++
 r2/r2/templates/newlink.html       | 20 ++++++++++----------
 r2/r2/templates/printable.html     |  2 +-
 4 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/r2/r2/public/static/css/reddit.css b/r2/r2/public/static/css/reddit.css
index 6a9df2d6f..f9522b96e 100644
--- a/r2/r2/public/static/css/reddit.css
+++ b/r2/r2/public/static/css/reddit.css
@@ -2036,6 +2036,7 @@ ul#image-preview-list .description pre {
     border: 1px solid gray;
     background: white;
     display: none;
+    left: 0;
 }
 
 #sr-drop-down  table { 
diff --git a/r2/r2/public/static/js/reddit.js b/r2/r2/public/static/js/reddit.js
index 0131b05d9..ceea205a0 100644
--- a/r2/r2/public/static/js/reddit.js
+++ b/r2/r2/public/static/js/reddit.js
@@ -639,6 +639,9 @@ function update_dropdown(sr_names) {
             drop_down.append(new_row);
         });
 
+
+    var height = $("#sr-autocomplete").outerHeight();
+    drop_down.css('top', height);
     drop_down.show();
 }
 
diff --git a/r2/r2/templates/newlink.html b/r2/r2/templates/newlink.html
index 5d2def1c4..81520eef1 100644
--- a/r2/r2/templates/newlink.html
+++ b/r2/r2/templates/newlink.html
@@ -47,8 +47,8 @@ ${thing.formtabs_menu.render()}
 <div class="spacer">
   <%utils:round_field title="${_('title')}" id="title-field">
     <textarea name="title" rows="2" cols="1" wrap="hard">${thing.title}</textarea>
-    ${error_field("NO_TEXT", "title", "span")}
-    ${error_field("TOO_LONG", "title", "span")}
+    ${error_field("NO_TEXT", "title", "div")}
+    ${error_field("TOO_LONG", "title", "div")}
   </%utils:round_field>
 </div>
 
@@ -56,11 +56,11 @@ ${thing.formtabs_menu.render()}
   <%utils:round_field title="${_('url')}" id="url-field">
     <input name="kind" value="link" type="hidden"/>
     <input id="url" name="url" type="text" value="${thing.url}"/>
-    ${error_field("NO_URL", "url", "span")}
-    ${error_field("BAD_URL", "url", "span")}
-    ${error_field("ALREADY_SUB", "url", "span")}
+    ${error_field("NO_URL", "url", "div")}
+    ${error_field("BAD_URL", "url", "div")}
+    ${error_field("ALREADY_SUB", "url", "div")}
     <div>
-      <button type="button" onclick="fetch_title()">${_("suggest title")}</button>
+      <button type="button" tabindex="100" onclick="fetch_title()">${_("suggest title")}</button>
       <span class="title-status"></span>
     </div>
   </%utils:round_field>
@@ -92,15 +92,15 @@ ${thing.formtabs_menu.render()}
     <script type="text/javascript">
       reddit.sr_cache = ${unsafe(thing.sr_searches)};
     </script>
-    ${error_field("SUBREDDIT_NOEXIST", "sr", "span")}
-    ${error_field("SUBREDDIT_REQUIRED", "sr", "span")}
+    ${error_field("SUBREDDIT_NOEXIST", "sr", "div")}
+    ${error_field("SUBREDDIT_REQUIRED", "sr", "div")}
     
     <div id="suggested-reddits">
         <span class="">${_("popular choices")}&#32;</span>
       <ul>
         %for name in thing.subreddits:
         <li>
-          <a href="#" onclick="set_sr_name(this); return false">${name}</a>&#32;
+          <a href="#" tabindex="100" onclick="set_sr_name(this); return false">${name}</a>&#32;
         </li>
         %endfor
       </ul>
@@ -115,7 +115,7 @@ ${thing.formtabs_menu.render()}
 </div>
 
 <div class="spacer">
-  <button class="btn" name="submit" value="form" type="submit" tabindex=1>${_("submit")}</button>
+  <button class="btn" name="submit" value="form" type="submit">${_("submit")}</button>
   <span class="status"></span>
   ${error_field("RATELIMIT", "ratelimit")}
 </div>
diff --git a/r2/r2/templates/printable.html b/r2/r2/templates/printable.html
index 90991d3e3..c46af26a7 100644
--- a/r2/r2/templates/printable.html
+++ b/r2/r2/templates/printable.html
@@ -314,7 +314,7 @@ thing id-${what._fullname}
        css_class, alt_css_class = alt_css_class, css_class
  %>
 <span class="${class_name} toggle" style="${style}">
- <a class="option active ${css_class}" href="#" 
+ <a class="option active ${css_class}" href="#" tabindex="100"
     %if login_required and not c.user_is_loggedin:
       onclick="return showcover('', '${callback}_' + $(this).thing_id());"
     %else: