From da1896510675784be3fcd945056568b6826d18e8 Mon Sep 17 00:00:00 2001 From: Brian Simpson Date: Thu, 10 Apr 2014 15:27:00 -0700 Subject: [PATCH] PromoteReport: exclude end hour to avoid double counting. --- r2/r2/lib/pages/pages.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/r2/r2/lib/pages/pages.py b/r2/r2/lib/pages/pages.py index 6f800bc6f..e5c343816 100644 --- a/r2/r2/lib/pages/pages.py +++ b/r2/r2/lib/pages/pages.py @@ -3982,6 +3982,11 @@ class PromoteReport(Templated): codenames = campaigns_by_name.keys() start = (start - promote.timezone_offset).replace(tzinfo=None) end = (end - promote.timezone_offset).replace(tzinfo=None) + + # start and end are dates so we need to subtract an hour from end to + # only include 24 hours per day + end -= datetime.timedelta(hours=1) + hits = traffic_cls.campaign_history(codenames, start, end) sr_hits = defaultdict(int) fp_hits = defaultdict(int)