From dcff90aa0c7736783cf34b706f5d41b72997f20d Mon Sep 17 00:00:00 2001 From: Max Goodman Date: Wed, 9 Apr 2014 20:11:52 -0700 Subject: [PATCH] Track whether a subscription is the user's first in breadcrumbs. --- r2/r2/lib/template_helpers.py | 1 + r2/r2/public/static/js/analytics.js | 5 +++-- r2/r2/public/static/js/reddit.js | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/r2/r2/lib/template_helpers.py b/r2/r2/lib/template_helpers.py index ae114d498..dd82dc465 100755 --- a/r2/r2/lib/template_helpers.py +++ b/r2/r2/lib/template_helpers.py @@ -165,6 +165,7 @@ def js_config(extra_config=None): "new_window": bool(c.user.pref_newwindow), "vote_hash": c.vote_hash, "gold": gold, + "has_subscribed": logged and c.user.has_subscribed, } if extra_config: diff --git a/r2/r2/public/static/js/analytics.js b/r2/r2/public/static/js/analytics.js index d60012f08..9fc7f257b 100644 --- a/r2/r2/public/static/js/analytics.js +++ b/r2/r2/public/static/js/analytics.js @@ -131,7 +131,7 @@ r.analytics = { $el.data('trackerFired', true) }, - fireUITrackingPixel: function(action, srname) { + fireUITrackingPixel: function(action, srname, extraParams) { var pixel = new Image() pixel.src = r.config.uitracker_url + '?' + $.param( _.extend( @@ -140,7 +140,8 @@ r.analytics = { 'sr': srname, 'r': Math.round(Math.random() * 2147483647) // cachebuster }, - r.analytics.breadcrumbs.toParams() + r.analytics.breadcrumbs.toParams(), + extraParams ) ) }, diff --git a/r2/r2/public/static/js/reddit.js b/r2/r2/public/static/js/reddit.js index 16dea61b3..4badca068 100644 --- a/r2/r2/public/static/js/reddit.js +++ b/r2/r2/public/static/js/reddit.js @@ -299,7 +299,7 @@ function subscribe(reddit_name) { } $.things(reddit_name).find(".entry").addClass("likes"); $.request("subscribe", {sr: reddit_name, action: "sub"}); - r.analytics.fireUITrackingPixel("sub", reddit_name) + r.analytics.fireUITrackingPixel("sub", reddit_name, {"has_subd": r.config.has_subscribed}) } }; };