From ea6b7de98c0225b432eac4eb7de72a4f8748598f Mon Sep 17 00:00:00 2001 From: Brian Simpson Date: Mon, 10 Feb 2014 23:38:25 -0500 Subject: [PATCH] terminate_campaign: Set link to finished if it has no live campaigns. --- r2/r2/lib/promote.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/r2/r2/lib/promote.py b/r2/r2/lib/promote.py index 55bda78d3..9a9797ca6 100644 --- a/r2/r2/lib/promote.py +++ b/r2/r2/lib/promote.py @@ -293,8 +293,12 @@ def terminate_campaign(link, campaign): edit_campaign(link, campaign, dates, campaign.bid, campaign.cpm, sr, campaign.priority, campaign.location) - update_promote_status(link, PROMOTE_STATUS.finished) - all_live_promo_srnames(_update=True) + campaigns = list(PromoCampaign._by_link(link._id)) + is_live = any(is_live_promo(link, camp) for camp in campaigns + if camp._id != campaign._id) + if not is_live: + update_promote_status(link, PROMOTE_STATUS.finished) + all_live_promo_srnames(_update=True) msg = 'terminated campaign %s (original end %s)' % (campaign._id, original_end.date())