reddit

mirror of https://github.com/reddit-archive/reddit.git synced 2026-01-23 05:48:11 -05:00

Files

Neil Williams 19c497dff3 New comment highlighting: restrict scope of timestamp selector.

In reworking new comment highlighting I introduced a regression that
caused child comments to share the timestamp of their parent regardless
of their own time. This was caused by an insufficiently specific
selector.

The structure of a nested comment view looks like:

    <div class="comment">
        <div class="entry">
            <p class="tagline">
                <time>
                <time class="edited-timestamp">
        <div class="child">
            <div class="listing">
                <div class="comment">
                    ...

Selecting '.tagline time' from beneath '.comment' would pick up child
comment timestamps as well and we'd overwrite their timestamp cache. We
would also pick up edited timestamps, but that doesn't appear to do
anything bad since they're not live.

This fixes the bug by specifically sticking to the direct descendants.

2015-04-09 08:59:32 -07:00