mirror of
https://github.com/reddit-archive/reddit.git
synced 2026-04-27 03:00:12 -04:00
e454857b31
`add_sr()` has had, since reddit/reddit@b57dff70, a special-case when the requested page was on https, where it would ignore whatever domain it would normally set and use the current one instead. As best as we can tell, this was to prevent issues with a lack of https support on all reddit domains, eg links on `https://pay.reddit.com` pointing to `https://www.reddit.com`. This should no longer be an issue. Additionally, it has caused problems with the comment embeds, which are served from `redditmedia.com` but need to have links pointing to `www.reddit.com`. Now that this special-case doesn't exist, the function should act more intuitively. And hopefully that doesn't break anything too badly. :p The request from the comment embed javascript to get the actual embed has been going through `g.media_domain`. This in turn meant that sometimes (namely, when the embed was placed on an https page) the link to the comment was also heading through the media domain. While this works, we'd rather have users go through the standard `www.reddit.com` domain for brand, caching, and probably other infrastructure reasons.