From 5f6e166bce95c969d58ea0fcc357a779cc32bdc4 Mon Sep 17 00:00:00 2001 From: Andy Pan Date: Wed, 21 Apr 2021 14:04:36 +0800 Subject: [PATCH] Shrink code lines and reduce code cyclomatic complexity (#8748) code cleanup in anetGenericAccept --- src/anet.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/anet.c b/src/anet.c index a121c27689..ee78703c7c 100644 --- a/src/anet.c +++ b/src/anet.c @@ -493,17 +493,12 @@ int anetUnixServer(char *err, char *path, mode_t perm, int backlog) static int anetGenericAccept(char *err, int s, struct sockaddr *sa, socklen_t *len) { int fd; - while(1) { + do { fd = accept(s,sa,len); - if (fd == -1) { - if (errno == EINTR) - continue; - else { - anetSetError(err, "accept: %s", strerror(errno)); - return ANET_ERR; - } - } - break; + } while(fd == -1 && errno == EINTR); + if (fd == -1) { + anetSetError(err, "accept: %s", strerror(errno)); + return ANET_ERR; } return fd; }