From 83c0348553248fde3283a85dc9b036197a06e66a Mon Sep 17 00:00:00 2001 From: kei-nan Date: Wed, 5 Feb 2025 10:01:24 +0200 Subject: [PATCH] Apply suggestions from code review * apply comment suggestions Co-authored-by: Oran Agra --- src/module.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/module.c b/src/module.c index 08389035d6..eae07bb066 100644 --- a/src/module.c +++ b/src/module.c @@ -13286,11 +13286,8 @@ int RM_RegisterNumericConfig(RedisModuleCtx *ctx, const char *name, long long de /* Applies all default configurations for the parameters the module registered. * Only call this function if the module would like to make changes to the * configuration values before the actual values are applied by RedisModule_LoadConfigs. - * Otherwise continue calling RedisModule_LoadConfigs, it should already set the default values if needed. - * This sets an ordering for the possible source of a configuration value: - * 1. config values - e.g from the config file or CONFIG during loadex - * 2. module values - e.g from the module arguments - * 3. default values - if no other value was set + * Otherwise it's sufficient to call RedisModule_LoadConfigs, it should already set the default values if needed. + * This makes it possible to distinguish between default values and user provided values and apply other changes between setting the defaults and the user values.``` * This will return REDISMODULE_ERR if it is called: * 1. outside RedisModule_OnLoad * 2. more than once