From 85899e359ee7c4e615477b82b8b1d5c6f258d792 Mon Sep 17 00:00:00 2001 From: Moti Cohen Date: Tue, 19 Apr 2022 06:04:10 +0300 Subject: [PATCH] Fix sdsConfigRewrite() to prevent freeing invalid memory(#10598) --- src/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/config.c b/src/config.c index cb3ff2e45e..5ebf381c84 100644 --- a/src/config.c +++ b/src/config.c @@ -1848,7 +1848,7 @@ static sds sdsConfigGet(standardConfig *config) { static void sdsConfigRewrite(standardConfig *config, const char *name, struct rewriteConfigState *state) { sds val = config->flags & MODULE_CONFIG ? getModuleStringConfig(config->privdata) : *config->data.sds.config; rewriteConfigSdsOption(state, name, val, config->data.sds.default_value); - if (val) sdsfree(val); + if ((val) && (config->flags & MODULE_CONFIG)) sdsfree(val); }