From efc8a6beee5f8ed034b2c31df3d72cd6eec6df9e Mon Sep 17 00:00:00 2001 From: antirez Date: Fri, 3 Sep 2010 11:30:26 +0200 Subject: [PATCH] BLPOP inside MULTI/EXEC block no longer crashes, instead if the list is empty the behavior is like if the timeout is reached. This fixes Issue 285 (backported from master) --- redis.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/redis.c b/redis.c index 10fe937b4b..59f84f17d2 100644 --- a/redis.c +++ b/redis.c @@ -7752,6 +7752,14 @@ static void blockingPopGenericCommand(redisClient *c, int where) { } } } + + /* If we are inside a MULTI/EXEC and the list is empty the only thing + * we can do is treating it as a timeout (even with timeout 0). */ + if (c->flags & REDIS_MULTI) { + addReply(c,shared.nullmultibulk); + return; + } + /* If the list is empty or the key does not exists we must block */ timeout = strtol(c->argv[c->argc-1]->ptr,NULL,10); if (timeout > 0) timeout += time(NULL);