mirror of
https://github.com/redis/redis.git
synced 2026-04-21 03:01:35 -04:00
843a4cdc07
This PR does 2 main things:
1) Add warning for suspected slow system clocksource setting. This is Linux specific.
2) Add a `--check-system` argument to redis which runs all system checks and prints a report.
## System checks
Add a command line option `--check-system` which runs all known system checks and provides
a report to stdout of which systems checks have failed with details on how to reconfigure the
system for optimized redis performance.
The `--system-check` mode exists with an appropriate error code after running all the checks.
## Slow clocksource details
We check the system's clocksource performance by running `clock_gettime()` in a loop and then
checking how much time was spent in a system call (via `getrusage()`). If we spend more than
10% of the time in the kernel then we print a warning. I verified that using the slow clock sources:
`acpi_pm` (~90% in the kernel on my laptop) and `xen` (~30% in the kernel on an ec2 `m4.large`)
we get this warning.
The check runs 5 system ticks so we can detect time spent in kernel at 20% jumps (0%,20%,40%...).
Anything more accurate will require the test to run longer. Typically 5 ticks are 50ms. This means
running the test on startup will delay startup by 50ms. To avoid this we make sure the test is only
executed in the `--check-system` mode.
For a quick startup check, we specifically warn if the we see the system is using the `xen` clocksource
which we know has bad performance and isn't recommended (at least on ec2). In such a case the
user should manually rung redis with `--check-system` to force the slower clocksource test described
above.
## Other changes in the PR
* All the system checks are now implemented as functions in _syscheck.c_.
They are implemented using a standard interface (see details in _syscheck.c_).
To do this I moved the checking functions `linuxOvercommitMemoryValue()`,
`THPIsEnabled()`, `linuxMadvFreeForkBugCheck()` out of _server.c_ and _latency.c_
and into the new _syscheck.c_. When moving these functions I made sure they don't
depend on other functionality provided in _server.c_ and made them use a standard
"check functions" interface. Specifically:
* I removed all logging out of `linuxMadvFreeForkBugCheck()`. In case there's some
unexpected error during the check aborts as before, but without any logging.
It returns an error code 0 meaning the check didn't not complete.
* All these functions now return 1 on success, -1 on failure, 0 in case the check itself
cannot be completed.
* The `linuxMadvFreeForkBugCheck()` function now internally calls `exit()` and not
`exitFromChild()` because the latter is only available in _server.c_ and I wanted to
remove that dependency. This isn't an because we don't need to worry about the
child process created by the test doing anything related to the rdb/aof files which
is why `exitFromChild()` was created.
* This also fixes parsing of other /proc/\<pid\>/stat fields to correctly handle spaces
in the process name and be more robust in general. Not that before this fix the rss
info in `INFO memory` was corrupt in case of spaces in the process name. To
recreate just rename `redis-server` to `redis server`, start it, and run `INFO memory`.
146 lines
5.2 KiB
C
146 lines
5.2 KiB
C
/* zmalloc - total amount of allocated memory aware version of malloc()
|
|
*
|
|
* Copyright (c) 2009-2010, Salvatore Sanfilippo <antirez at gmail dot com>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above copyright notice,
|
|
* this list of conditions and the following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* * Neither the name of Redis nor the names of its contributors may be used
|
|
* to endorse or promote products derived from this software without
|
|
* specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#ifndef __ZMALLOC_H
|
|
#define __ZMALLOC_H
|
|
|
|
/* Double expansion needed for stringification of macro values. */
|
|
#define __xstr(s) __str(s)
|
|
#define __str(s) #s
|
|
|
|
#if defined(USE_TCMALLOC)
|
|
#define ZMALLOC_LIB ("tcmalloc-" __xstr(TC_VERSION_MAJOR) "." __xstr(TC_VERSION_MINOR))
|
|
#include <google/tcmalloc.h>
|
|
#if (TC_VERSION_MAJOR == 1 && TC_VERSION_MINOR >= 6) || (TC_VERSION_MAJOR > 1)
|
|
#define HAVE_MALLOC_SIZE 1
|
|
#define zmalloc_size(p) tc_malloc_size(p)
|
|
#else
|
|
#error "Newer version of tcmalloc required"
|
|
#endif
|
|
|
|
#elif defined(USE_JEMALLOC)
|
|
#define ZMALLOC_LIB ("jemalloc-" __xstr(JEMALLOC_VERSION_MAJOR) "." __xstr(JEMALLOC_VERSION_MINOR) "." __xstr(JEMALLOC_VERSION_BUGFIX))
|
|
#include <jemalloc/jemalloc.h>
|
|
#if (JEMALLOC_VERSION_MAJOR == 2 && JEMALLOC_VERSION_MINOR >= 1) || (JEMALLOC_VERSION_MAJOR > 2)
|
|
#define HAVE_MALLOC_SIZE 1
|
|
#define zmalloc_size(p) je_malloc_usable_size(p)
|
|
#else
|
|
#error "Newer version of jemalloc required"
|
|
#endif
|
|
|
|
#elif defined(__APPLE__)
|
|
#include <malloc/malloc.h>
|
|
#define HAVE_MALLOC_SIZE 1
|
|
#define zmalloc_size(p) malloc_size(p)
|
|
#endif
|
|
|
|
/* On native libc implementations, we should still do our best to provide a
|
|
* HAVE_MALLOC_SIZE capability. This can be set explicitly as well:
|
|
*
|
|
* NO_MALLOC_USABLE_SIZE disables it on all platforms, even if they are
|
|
* known to support it.
|
|
* USE_MALLOC_USABLE_SIZE forces use of malloc_usable_size() regardless
|
|
* of platform.
|
|
*/
|
|
#ifndef ZMALLOC_LIB
|
|
#define ZMALLOC_LIB "libc"
|
|
|
|
#if !defined(NO_MALLOC_USABLE_SIZE) && \
|
|
(defined(__GLIBC__) || defined(__FreeBSD__) || \
|
|
defined(USE_MALLOC_USABLE_SIZE))
|
|
|
|
/* Includes for malloc_usable_size() */
|
|
#ifdef __FreeBSD__
|
|
#include <malloc_np.h>
|
|
#else
|
|
#include <malloc.h>
|
|
#endif
|
|
|
|
#define HAVE_MALLOC_SIZE 1
|
|
#define zmalloc_size(p) malloc_usable_size(p)
|
|
|
|
#endif
|
|
#endif
|
|
|
|
/* We can enable the Redis defrag capabilities only if we are using Jemalloc
|
|
* and the version used is our special version modified for Redis having
|
|
* the ability to return per-allocation fragmentation hints. */
|
|
#if defined(USE_JEMALLOC) && defined(JEMALLOC_FRAG_HINT)
|
|
#define HAVE_DEFRAG
|
|
#endif
|
|
|
|
void *zmalloc(size_t size);
|
|
void *zcalloc(size_t size);
|
|
void *zcalloc_num(size_t num, size_t size);
|
|
void *zrealloc(void *ptr, size_t size);
|
|
void *ztrymalloc(size_t size);
|
|
void *ztrycalloc(size_t size);
|
|
void *ztryrealloc(void *ptr, size_t size);
|
|
void zfree(void *ptr);
|
|
void *zmalloc_usable(size_t size, size_t *usable);
|
|
void *zcalloc_usable(size_t size, size_t *usable);
|
|
void *zrealloc_usable(void *ptr, size_t size, size_t *usable);
|
|
void *ztrymalloc_usable(size_t size, size_t *usable);
|
|
void *ztrycalloc_usable(size_t size, size_t *usable);
|
|
void *ztryrealloc_usable(void *ptr, size_t size, size_t *usable);
|
|
void zfree_usable(void *ptr, size_t *usable);
|
|
char *zstrdup(const char *s);
|
|
size_t zmalloc_used_memory(void);
|
|
void zmalloc_set_oom_handler(void (*oom_handler)(size_t));
|
|
size_t zmalloc_get_rss(void);
|
|
int zmalloc_get_allocator_info(size_t *allocated, size_t *active, size_t *resident);
|
|
void set_jemalloc_bg_thread(int enable);
|
|
int jemalloc_purge();
|
|
size_t zmalloc_get_private_dirty(long pid);
|
|
size_t zmalloc_get_smap_bytes_by_field(char *field, long pid);
|
|
size_t zmalloc_get_memory_size(void);
|
|
void zlibc_free(void *ptr);
|
|
void zmadvise_dontneed(void *ptr);
|
|
|
|
#ifdef HAVE_DEFRAG
|
|
void zfree_no_tcache(void *ptr);
|
|
void *zmalloc_no_tcache(size_t size);
|
|
#endif
|
|
|
|
#ifndef HAVE_MALLOC_SIZE
|
|
size_t zmalloc_size(void *ptr);
|
|
size_t zmalloc_usable_size(void *ptr);
|
|
#else
|
|
#define zmalloc_usable_size(p) zmalloc_size(p)
|
|
#endif
|
|
|
|
int get_proc_stat_ll(int i, long long *res);
|
|
|
|
#ifdef REDIS_TEST
|
|
int zmalloc_test(int argc, char **argv, int flags);
|
|
#endif
|
|
|
|
#endif /* __ZMALLOC_H */
|