Files
redis/src/connection.c
Ozan Tezcan 3761fdb048 Use cached value correctly inside connectionTypeTls() (#11236)
When Redis is built without TLS support, connectionTypeTls() function 
keeps searching connection type as cached connection type is NULL. 

Added another variable to track if we cached the connection type to 
prevent search after the first time. 

Noticed a log warning message is printed repeatedly by connectionTypeTls.

Co-authored-by: zhenwei pi <pizhenwei@bytedance.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
2022-09-06 09:04:33 +03:00

209 lines
5.7 KiB
C

/* ==========================================================================
* connection.c - connection layer framework
* --------------------------------------------------------------------------
* Copyright (C) 2022 zhenwei pi
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the
* "Software"), to deal in the Software without restriction, including
* without limitation the rights to use, copy, modify, merge, publish,
* distribute, sublicense, and/or sell copies of the Software, and to permit
* persons to whom the Software is furnished to do so, subject to the
* following conditions:
*
* The above copyright notice and this permission notice shall be included
* in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
* NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
* DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
* USE OR OTHER DEALINGS IN THE SOFTWARE.
* ==========================================================================
*/
#include "server.h"
#include "connection.h"
static ConnectionType *connTypes[CONN_TYPE_MAX];
int connTypeRegister(ConnectionType *ct) {
const char *typename = ct->get_type(NULL);
ConnectionType *tmpct;
int type;
/* find an empty slot to store the new connection type */
for (type = 0; type < CONN_TYPE_MAX; type++) {
tmpct = connTypes[type];
if (!tmpct)
break;
/* ignore case, we really don't care "tls"/"TLS" */
if (!strcasecmp(typename, tmpct->get_type(NULL))) {
serverLog(LL_WARNING, "Connection types %s already registered", typename);
return C_ERR;
}
}
serverLog(LL_VERBOSE, "Connection type %s registered", typename);
connTypes[type] = ct;
if (ct->init) {
ct->init();
}
return C_OK;
}
int connTypeInitialize() {
/* currently socket connection type is necessary */
serverAssert(RedisRegisterConnectionTypeSocket() == C_OK);
/* currently unix socket connection type is necessary */
serverAssert(RedisRegisterConnectionTypeUnix() == C_OK);
/* may fail if without BUILD_TLS=yes */
RedisRegisterConnectionTypeTLS();
return C_OK;
}
ConnectionType *connectionByType(const char *typename) {
ConnectionType *ct;
for (int type = 0; type < CONN_TYPE_MAX; type++) {
ct = connTypes[type];
if (!ct)
break;
if (!strcasecmp(typename, ct->get_type(NULL)))
return ct;
}
serverLog(LL_WARNING, "Missing implement of connection type %s", typename);
return NULL;
}
/* Cache TCP connection type, query it by string once */
ConnectionType *connectionTypeTcp() {
static ConnectionType *ct_tcp = NULL;
if (ct_tcp != NULL)
return ct_tcp;
ct_tcp = connectionByType(CONN_TYPE_SOCKET);
serverAssert(ct_tcp != NULL);
return ct_tcp;
}
/* Cache TLS connection type, query it by string once */
ConnectionType *connectionTypeTls() {
static ConnectionType *ct_tls = NULL;
static int cached = 0;
/* Unlike the TCP and Unix connections, the TLS one can be missing
* So we need the cached pointer to handle NULL correctly too. */
if (!cached) {
cached = 1;
ct_tls = connectionByType(CONN_TYPE_TLS);
}
return ct_tls;
}
/* Cache Unix connection type, query it by string once */
ConnectionType *connectionTypeUnix() {
static ConnectionType *ct_unix = NULL;
if (ct_unix != NULL)
return ct_unix;
ct_unix = connectionByType(CONN_TYPE_UNIX);
return ct_unix;
}
int connectionIndexByType(const char *typename) {
ConnectionType *ct;
for (int type = 0; type < CONN_TYPE_MAX; type++) {
ct = connTypes[type];
if (!ct)
break;
if (!strcasecmp(typename, ct->get_type(NULL)))
return type;
}
return -1;
}
void connTypeCleanupAll() {
ConnectionType *ct;
int type;
for (type = 0; type < CONN_TYPE_MAX; type++) {
ct = connTypes[type];
if (!ct)
break;
if (ct->cleanup)
ct->cleanup();
}
}
/* walk all the connection types until has pending data */
int connTypeHasPendingData(void) {
ConnectionType *ct;
int type;
int ret = 0;
for (type = 0; type < CONN_TYPE_MAX; type++) {
ct = connTypes[type];
if (ct && ct->has_pending_data && (ret = ct->has_pending_data())) {
return ret;
}
}
return ret;
}
/* walk all the connection types and process pending data for each connection type */
int connTypeProcessPendingData(void) {
ConnectionType *ct;
int type;
int ret = 0;
for (type = 0; type < CONN_TYPE_MAX; type++) {
ct = connTypes[type];
if (ct && ct->process_pending_data) {
ret += ct->process_pending_data();
}
}
return ret;
}
sds getListensInfoString(sds info) {
for (int j = 0; j < CONN_TYPE_MAX; j++) {
connListener *listener = &server.listeners[j];
if (listener->ct == NULL)
continue;
info = sdscatfmt(info, "listener%i:name=%s", j, listener->ct->get_type(NULL));
for (int i = 0; i < listener->count; i++) {
info = sdscatfmt(info, ",bind=%s", listener->bindaddr[i]);
}
if (listener->port)
info = sdscatfmt(info, ",port=%i", listener->port);
info = sdscatfmt(info, "\r\n");
}
return info;
}