From aa06b84f0a95fdb77be0dd85d6d6cccb03bd22e1 Mon Sep 17 00:00:00 2001
From: Daniel Graf <daniel@dedicatedcode.com>
Date: Mon, 3 Nov 2025 09:01:20 +0100
Subject: [PATCH] 391 nosuchelementexception while creatingregenerating
 memories (#393)

---
 .../reitti/service/MemoryBlockGenerationService.java     | 9 +++++----
 src/main/resources/messages.properties                   | 1 +
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/main/java/com/dedicatedcode/reitti/service/MemoryBlockGenerationService.java b/src/main/java/com/dedicatedcode/reitti/service/MemoryBlockGenerationService.java
index c7ef4f3d..4f1f6eb4 100644
--- a/src/main/java/com/dedicatedcode/reitti/service/MemoryBlockGenerationService.java
+++ b/src/main/java/com/dedicatedcode/reitti/service/MemoryBlockGenerationService.java
@@ -189,10 +189,11 @@ public class MemoryBlockGenerationService {
                         .filter(trip -> trip.getEndTime() != null && (trip.getEndTime().equals(cluster.getStartTime())))
                         .sorted(Comparator.comparing(Trip::getEndTime))
                         .toList();
-
-                if (Duration.between(tripsBetweenVisits.getFirst().getStartTime(), tripsBetweenVisits.getLast().getEndTime()).toMinutes() > 30) {
-                    MemoryClusterBlock clusterBlock = convertToTripCluster(tripsBetweenVisits, "Journey to " + cluster.getHighestScoredVisit().visit().getPlace().getCity());
-                    blockParts.add(clusterBlock);
+                if (!tripsBetweenVisits.isEmpty() && cluster.getHighestScoredVisit() != null) {
+                    if (Duration.between(tripsBetweenVisits.getFirst().getStartTime(), tripsBetweenVisits.getLast().getEndTime()).toMinutes() > 30) {
+                        MemoryClusterBlock clusterBlock = convertToTripCluster(tripsBetweenVisits, i18n.translate("memory.generator.journey_to.headline.text", cluster.getHighestScoredVisit().visit().getPlace().getCity()));
+                        blockParts.add(clusterBlock);
+                    }
                 }
                 previousVisit = cluster.getVisits().stream().map(ScoredVisit::visit).max(Comparator.comparing(ProcessedVisit::getEndTime)).orElse(null);
             }
diff --git a/src/main/resources/messages.properties b/src/main/resources/messages.properties
index 2932ca69..6574345a 100644
--- a/src/main/resources/messages.properties
+++ b/src/main/resources/messages.properties
@@ -1100,6 +1100,7 @@ memory.view.block.cluster_visit.duration=Spent {0} hours {1} minutes.
 
 memory.generator.day.text=Day {0}: {1}
 memory.generator.headline.text=Our Journey
+memory.generator.journey_to.headline.text=Journey to {0}
 
 memory.generator.introductory.text=What an unforgettable adventure we had! Our journey began on {0} as we set out from {1}, and for the \
   next {2} days, we made {3}, {4} our wonderful home base. \