From 016c445dfa5c4ea920ca0399f6aefd70d3cb04c4 Mon Sep 17 00:00:00 2001 From: Derek Cofausper <256792747+decofe@users.noreply.github.com> Date: Wed, 4 Mar 2026 12:28:47 -0800 Subject: [PATCH] fix(reth-bench): off-by-one when deriving --from from engine head (#22788) Co-authored-by: Alexey Shekhirin <5773434+shekhirin@users.noreply.github.com> --- bin/reth-bench/src/bench/context.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/reth-bench/src/bench/context.rs b/bin/reth-bench/src/bench/context.rs index 2314c3eb71..04fd8c7470 100644 --- a/bin/reth-bench/src/bench/context.rs +++ b/bin/reth-bench/src/bench/context.rs @@ -92,7 +92,7 @@ impl BenchContext { // - `from = head + 1` // - `to = head + advance` // - If only `--to` is provided, fetches the latest block from the engine and sets: - // - `from = head + 1` + // - `from = head` // - Otherwise, uses the values from `--from` and `--to`. let (from, to) = if let Some(advance) = bench_args.advance { if advance == 0 { @@ -112,7 +112,7 @@ impl BenchContext { .ok_or_else(|| eyre::eyre!("Failed to fetch latest block from engine"))?; let head_number = head_block.header.number; info!(target: "reth-bench", "No --from provided, derived from engine head: {}", head_number); - (Some(head_number + 1), bench_args.to) + (Some(head_number), bench_args.to) } else { (bench_args.from, bench_args.to) };