From 1406a984a7d839fb00f499fcf36cd52565734784 Mon Sep 17 00:00:00 2001 From: Georgios Konstantopoulos Date: Tue, 10 Feb 2026 23:21:38 -0500 Subject: [PATCH] ci: pass --no-fail-fast to all cargo nextest runs (#22046) Co-authored-by: Amp --- .github/workflows/e2e.yml | 2 ++ .github/workflows/integration.yml | 3 ++- .github/workflows/unit.yml | 3 ++- Makefile | 4 ++-- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index f1c0c9fffe..c2a115198c 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -35,6 +35,7 @@ jobs: - name: Run e2e tests run: | cargo nextest run \ + --no-fail-fast \ --locked --features "asm-keccak" \ --workspace \ --exclude 'example-*' \ @@ -61,6 +62,7 @@ jobs: - name: Run RocksDB e2e tests run: | cargo nextest run \ + --no-fail-fast \ --locked --features "edge" \ -p reth-e2e-test-utils \ -E 'binary(rocksdb)' diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 1ba1b9460e..901de86615 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -46,6 +46,7 @@ jobs: - name: Run tests run: | cargo nextest run \ + --no-fail-fast \ --locked --features "asm-keccak ${{ matrix.network }} ${{ matrix.storage == 'edge' && 'edge' || '' }}" \ --workspace --exclude ef-tests \ -E "kind(test) and not binary(e2e_testsuite)" @@ -76,4 +77,4 @@ jobs: with: cache-on-failure: true - name: run era1 files integration tests - run: cargo nextest run --release --package reth-era --test it -- --ignored + run: cargo nextest run --no-fail-fast --release --package reth-era --test it -- --ignored diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml index 4fbed70ced..d5386cf41e 100644 --- a/.github/workflows/unit.yml +++ b/.github/workflows/unit.yml @@ -49,6 +49,7 @@ jobs: - name: Run tests run: | cargo nextest run \ + --no-fail-fast \ --features "${{ matrix.features }} $EDGE_FEATURES" --locked \ ${{ matrix.exclude_args }} --workspace \ --exclude ef-tests --no-tests=warn \ @@ -87,7 +88,7 @@ jobs: - uses: Swatinem/rust-cache@v2 with: cache-on-failure: true - - run: cargo nextest run --cargo-profile hivetests -p ef-tests --features "asm-keccak ef-tests" + - run: cargo nextest run --no-fail-fast --cargo-profile hivetests -p ef-tests --features "asm-keccak ef-tests" doc: name: doc tests diff --git a/Makefile b/Makefile index 92a5e58863..2d1619929f 100644 --- a/Makefile +++ b/Makefile @@ -153,7 +153,7 @@ COV_FILE := lcov.info .PHONY: test-unit test-unit: ## Run unit tests. cargo install cargo-nextest --locked - cargo nextest run $(UNIT_TEST_ARGS) + cargo nextest run --no-fail-fast $(UNIT_TEST_ARGS) .PHONY: cov-unit @@ -186,7 +186,7 @@ $(EEST_TESTS_DIR): .PHONY: ef-tests ef-tests: $(EF_TESTS_DIR) $(EEST_TESTS_DIR) ## Runs Legacy and EEST tests. - cargo nextest run -p ef-tests --release --features ef-tests + cargo nextest run --no-fail-fast -p ef-tests --release --features ef-tests ##@ reth-bench