From 217a337d8c5330407b7915370c046976a39eb71f Mon Sep 17 00:00:00 2001 From: Georgios Konstantopoulos Date: Thu, 12 Feb 2026 00:45:45 -0500 Subject: [PATCH] chore(engine): remove biased select in engine service loop (#21961) Co-authored-by: Amp Co-authored-by: joshieDo <93316087+joshieDo@users.noreply.github.com> --- .changelog/lazy-lakes-shout.md | 5 +++++ crates/node/builder/src/launch/engine.rs | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 .changelog/lazy-lakes-shout.md diff --git a/.changelog/lazy-lakes-shout.md b/.changelog/lazy-lakes-shout.md new file mode 100644 index 0000000000..30774e7c81 --- /dev/null +++ b/.changelog/lazy-lakes-shout.md @@ -0,0 +1,5 @@ +--- +reth-node-builder: patch +--- + +Removed biased select in engine service loop to allow fair scheduling of shutdown requests alongside event processing. diff --git a/crates/node/builder/src/launch/engine.rs b/crates/node/builder/src/launch/engine.rs index ce13198a34..31a21d1668 100644 --- a/crates/node/builder/src/launch/engine.rs +++ b/crates/node/builder/src/launch/engine.rs @@ -303,8 +303,6 @@ impl EngineNodeLauncher { // the CL loop { tokio::select! { - biased; - event = engine_service.next() => { let Some(event) = event else { break }; debug!(target: "reth::cli", "Event: {event}");