github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-02-19 03:04:27 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(rocksdb): flush memtables before dropping (#21234)

Browse Source
This commit is contained in:
joshieDo
2026-01-21 02:19:36 +00:00
committed by GitHub
parent 660964a0f5
commit 238433e146
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
crates/storage/provider/src/providers/rocksdb/provider.rs
View File

@@ -427,7 +427,17 @@ impl fmt::Debug for RocksDBProviderInner {
impl Drop for RocksDBProviderInner {
fn drop(&mut self) {
match self {
Self::ReadWrite { db, .. } => db.cancel_all_background_work(true),
Self::ReadWrite { db, .. } => {
// Flush all memtables if possible. If not, they will be rebuilt from the WAL on
// restart
if let Err(e) = db.flush_wal(true) {
tracing::warn!(target: "storage::rocksdb", ?e, "Failed to flush WAL on drop");
}
if let Err(e) = db.flush() {
tracing::warn!(target: "storage::rocksdb", ?e, "Failed to flush memtables on drop");
}
db.cancel_all_background_work(true);
}
Self::ReadOnly { db, .. } => db.cancel_all_background_work(true),
}
}