From 47cef33a0d80a666c9c705cf3c766c00a9818ff4 Mon Sep 17 00:00:00 2001 From: Georgios Konstantopoulos Date: Sun, 15 Feb 2026 17:41:05 -0800 Subject: [PATCH] fix: record bare tracing instrument fields (#22207) Co-authored-by: Amp --- crates/engine/tree/src/persistence.rs | 2 +- crates/engine/tree/src/tree/mod.rs | 2 +- crates/engine/tree/src/tree/payload_validator.rs | 2 +- crates/net/network/src/session/mod.rs | 2 +- crates/storage/provider/src/providers/state/overlay.rs | 2 +- crates/trie/sparse/src/state.rs | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/crates/engine/tree/src/persistence.rs b/crates/engine/tree/src/persistence.rs index cb7994d9c5..59e567dc0a 100644 --- a/crates/engine/tree/src/persistence.rs +++ b/crates/engine/tree/src/persistence.rs @@ -119,7 +119,7 @@ where Ok(()) } - #[instrument(level = "debug", target = "engine::persistence", skip_all, fields(new_tip_num))] + #[instrument(level = "debug", target = "engine::persistence", skip_all, fields(%new_tip_num))] fn on_remove_blocks_above( &self, new_tip_num: u64, diff --git a/crates/engine/tree/src/tree/mod.rs b/crates/engine/tree/src/tree/mod.rs index 49bcacccde..bced266835 100644 --- a/crates/engine/tree/src/tree/mod.rs +++ b/crates/engine/tree/src/tree/mod.rs @@ -2602,7 +2602,7 @@ where /// Returns `InsertPayloadOk::Inserted(BlockStatus::Valid)` on successful execution, /// `InsertPayloadOk::AlreadySeen` if the block already exists, or /// `InsertPayloadOk::Inserted(BlockStatus::Disconnected)` if parent state is missing. - #[instrument(level = "debug", target = "engine::tree", skip_all, fields(block_id))] + #[instrument(level = "debug", target = "engine::tree", skip_all, fields(?block_id))] fn insert_block_or_payload( &mut self, block_id: BlockWithParent, diff --git a/crates/engine/tree/src/tree/payload_validator.rs b/crates/engine/tree/src/tree/payload_validator.rs index 62228a6adc..33759d65f2 100644 --- a/crates/engine/tree/src/tree/payload_validator.rs +++ b/crates/engine/tree/src/tree/payload_validator.rs @@ -1142,7 +1142,7 @@ where level = "debug", target = "engine::tree::payload_validator", skip_all, - fields(strategy) + fields(?strategy) )] fn spawn_payload_processor>( &mut self, diff --git a/crates/net/network/src/session/mod.rs b/crates/net/network/src/session/mod.rs index c0a75c647b..2ce3c29e3f 100644 --- a/crates/net/network/src/session/mod.rs +++ b/crates/net/network/src/session/mod.rs @@ -908,7 +908,7 @@ pub(crate) async fn start_pending_incoming_session( } /// Starts the authentication process for a connection initiated by a remote peer. -#[instrument(level = "trace", target = "net::network", skip_all, fields(%remote_addr, peer_id))] +#[instrument(level = "trace", target = "net::network", skip_all, fields(%remote_addr, peer_id = ?remote_peer_id))] #[expect(clippy::too_many_arguments)] async fn start_pending_outbound_session( handshake: Arc, diff --git a/crates/storage/provider/src/providers/state/overlay.rs b/crates/storage/provider/src/providers/state/overlay.rs index 350eeaf388..92bd6235dc 100644 --- a/crates/storage/provider/src/providers/state/overlay.rs +++ b/crates/storage/provider/src/providers/state/overlay.rs @@ -282,7 +282,7 @@ where level = "debug", target = "providers::state::overlay", skip_all, - fields(db_tip_block) + fields(%db_tip_block) )] fn calculate_overlay( &self, diff --git a/crates/trie/sparse/src/state.rs b/crates/trie/sparse/src/state.rs index 4fbb3c2839..2043b41a2a 100644 --- a/crates/trie/sparse/src/state.rs +++ b/crates/trie/sparse/src/state.rs @@ -1159,7 +1159,7 @@ where name = "SparseStateTrie::prune", target = "trie::sparse", skip_all, - fields(max_depth, max_storage_tries) + fields(%max_depth, %max_storage_tries) )] pub fn prune(&mut self, max_depth: usize, max_storage_tries: usize) { // Prune state and storage tries in parallel