github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-04-08 03:01:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore(engine): refactor sync target determination on failed fcu (#7704)

Browse Source
This commit is contained in:
Roman Krasiuk
2024-04-17 16:41:10 +02:00
committed by GitHub
parent 0a62b2735d
commit 4f8d90b104
1 changed files with 18 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
crates/consensus/beacon/src/engine/mod.rs
View File

@@ -988,42 +988,38 @@ where
}
}
// we assume the FCU is valid and at least the head is missing, so we need to start syncing
// to it
let target = if self.forkchoice_state_tracker.is_empty() {
// find the appropriate target to sync to, if we don't have the safe block hash then we
// start syncing to the safe block via pipeline first
let target = if !state.safe_block_hash.is_zero() &&
self.blockchain.block_number(state.safe_block_hash).ok().flatten().is_none()
{
state.safe_block_hash
} else {
state.head_block_hash
};
// we need to first check the buffer for the head and its ancestors
let lowest_unknown_hash = self.lowest_buffered_ancestor_or(target);
trace!(target: "consensus::engine", request=?lowest_unknown_hash, "Triggering full block download for missing ancestors of the new head");
lowest_unknown_hash
// we assume the FCU is valid and at least the head is missing,
// so we need to start syncing to it
//
// find the appropriate target to sync to, if we don't have the safe block hash then we
// start syncing to the safe block via pipeline first
let target = if self.forkchoice_state_tracker.is_empty() &&
// check that safe block is valid and missing
!state.safe_block_hash.is_zero() &&
self.blockchain.block_number(state.safe_block_hash).ok().flatten().is_none()
{
state.safe_block_hash
} else {
// we need to first check the buffer for the head and its ancestors
let lowest_unknown_hash = self.lowest_buffered_ancestor_or(state.head_block_hash);
trace!(target: "consensus::engine", request=?lowest_unknown_hash, "Triggering full block download for missing ancestors of the new head");
lowest_unknown_hash
state.head_block_hash
};
// we need to first check the buffer for the target and its ancestors
let target = self.lowest_buffered_ancestor_or(target);
// if the threshold is zero, we should not download the block first, and just use the
// pipeline. Otherwise we use the tree to insert the block first
if self.pipeline_run_threshold == 0 {
// use the pipeline to sync to the target
trace!(target: "consensus::engine", %target, "Triggering pipeline run to sync missing ancestors of the new head");
self.sync.set_pipeline_sync_target(target);
} else {
// trigger a full block download for missing hash, or the parent of its lowest buffered
// ancestor
trace!(target: "consensus::engine", request=%target, "Triggering full block download for missing ancestors of the new head");
self.sync.download_full_block(target);
}
debug!(target: "consensus::engine", ?target, "Syncing to new target");
debug!(target: "consensus::engine", %target, "Syncing to new target");
PayloadStatus::from_status(PayloadStatusEnum::Syncing)
}