From 6ace2fbbac5c087026a3703e0f2e15bf91e92528 Mon Sep 17 00:00:00 2001
From: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date: Thu, 15 Aug 2024 22:58:53 -0700
Subject: [PATCH] refactor(storage): small refactor in `convert_block_number`
 (#10364)

---
 crates/storage/storage-api/src/block_id.rs | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/crates/storage/storage-api/src/block_id.rs b/crates/storage/storage-api/src/block_id.rs
index db40dff24a..fbbf6fce55 100644
--- a/crates/storage/storage-api/src/block_id.rs
+++ b/crates/storage/storage-api/src/block_id.rs
@@ -62,14 +62,12 @@ pub trait BlockIdReader: BlockNumReader + Send + Sync {
                     .map(|res_opt| res_opt.map(|num_hash| num_hash.number))
             }
             BlockNumberOrTag::Number(num) => num,
-            BlockNumberOrTag::Finalized => match self.finalized_block_number()? {
-                Some(block_number) => block_number,
-                None => return Err(ProviderError::FinalizedBlockNotFound),
-            },
-            BlockNumberOrTag::Safe => match self.safe_block_number()? {
-                Some(block_number) => block_number,
-                None => return Err(ProviderError::SafeBlockNotFound),
-            },
+            BlockNumberOrTag::Finalized => {
+                self.finalized_block_number()?.ok_or(ProviderError::FinalizedBlockNotFound)?
+            }
+            BlockNumberOrTag::Safe => {
+                self.safe_block_number()?.ok_or(ProviderError::SafeBlockNotFound)?
+            }
         };
         Ok(Some(num))
     }