From 6b952dd948eff594a38726a732afcdc8cd0cafa4 Mon Sep 17 00:00:00 2001 From: Matthias Seitz Date: Fri, 27 Jan 2023 17:31:16 +0100 Subject: [PATCH] fix(net): prevent double reputation report (#1068) --- crates/net/network/src/session/active.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/net/network/src/session/active.rs b/crates/net/network/src/session/active.rs index 092ff4832b..8e5055429d 100644 --- a/crates/net/network/src/session/active.rs +++ b/crates/net/network/src/session/active.rs @@ -140,10 +140,9 @@ impl ActiveSession { self.update_request_timeout(req.timestamp, Instant::now()) } else { req.request.send_bad_response(); - self.on_bad_message(); } } else { - self.on_bad_message() + // TODO: this could be a late response to timed out request } }; } @@ -291,6 +290,7 @@ impl ActiveSession { } /// Notify the manager that the peer sent a bad message + #[allow(unused)] fn on_bad_message(&self) { let _ = self .to_session