diff --git a/crates/storage/provider/src/providers/blockchain_provider.rs b/crates/storage/provider/src/providers/blockchain_provider.rs index 4c03621507..e575441d85 100644 --- a/crates/storage/provider/src/providers/blockchain_provider.rs +++ b/crates/storage/provider/src/providers/blockchain_provider.rs @@ -582,7 +582,7 @@ impl BlockReader for BlockchainProvider2 { let mut stored_indices = self .database .block_body_indices(anchor_num)? - .ok_or_else(|| ProviderError::BlockBodyIndicesNotFound(anchor_num))?; + .ok_or(ProviderError::BlockBodyIndicesNotFound(anchor_num))?; stored_indices.first_tx_num = stored_indices.next_tx_num(); for state in parent_chain { diff --git a/crates/storage/provider/src/providers/database/provider.rs b/crates/storage/provider/src/providers/database/provider.rs index d232537004..8627cacabb 100644 --- a/crates/storage/provider/src/providers/database/provider.rs +++ b/crates/storage/provider/src/providers/database/provider.rs @@ -630,7 +630,7 @@ impl DatabaseProvider { // recover the sender from the transaction if not found let sender = tx .recover_signer_unchecked() - .ok_or_else(|| ProviderError::SenderRecoveryError)?; + .ok_or(ProviderError::SenderRecoveryError)?; senders.push(sender); } Some(sender) => senders.push(*sender), diff --git a/crates/storage/provider/src/providers/mod.rs b/crates/storage/provider/src/providers/mod.rs index 50b914778d..5fed81c155 100644 --- a/crates/storage/provider/src/providers/mod.rs +++ b/crates/storage/provider/src/providers/mod.rs @@ -120,7 +120,7 @@ impl BlockchainProvider { let best: ChainInfo = provider.chain_info()?; let latest_header = provider .header_by_number(best.best_number)? - .ok_or(ProviderError::HeaderNotFound(best.best_number.into()))?; + .ok_or_else(|| ProviderError::HeaderNotFound(best.best_number.into()))?; let finalized_header = provider .last_finalized_block_number()? diff --git a/crates/storage/provider/src/providers/static_file/manager.rs b/crates/storage/provider/src/providers/static_file/manager.rs index 9e6e925993..ec76e9504d 100644 --- a/crates/storage/provider/src/providers/static_file/manager.rs +++ b/crates/storage/provider/src/providers/static_file/manager.rs @@ -285,7 +285,9 @@ impl StaticFileProvider { let fixed_block_range = self.find_fixed_range(block_range.start()); let jar_provider = self .get_segment_provider(segment, || Some(fixed_block_range), None)? - .ok_or(ProviderError::MissingStaticFileBlock(segment, block_range.start()))?; + .ok_or_else(|| { + ProviderError::MissingStaticFileBlock(segment, block_range.start()) + })?; entries += jar_provider.rows(); @@ -323,7 +325,7 @@ impl StaticFileProvider { || self.get_segment_ranges_from_block(segment, block), path, )? - .ok_or_else(|| ProviderError::MissingStaticFileBlock(segment, block)) + .ok_or(ProviderError::MissingStaticFileBlock(segment, block)) } /// Gets the [`StaticFileJarProvider`] of the requested segment and transaction. @@ -338,7 +340,7 @@ impl StaticFileProvider { || self.get_segment_ranges_from_transaction(segment, tx), path, )? - .ok_or_else(|| ProviderError::MissingStaticFileTx(segment, tx)) + .ok_or(ProviderError::MissingStaticFileTx(segment, tx)) } /// Gets the [`StaticFileJarProvider`] of the requested segment and block or transaction. diff --git a/crates/storage/provider/src/writer/mod.rs b/crates/storage/provider/src/writer/mod.rs index aa60605d05..ecb1de3355 100644 --- a/crates/storage/provider/src/writer/mod.rs +++ b/crates/storage/provider/src/writer/mod.rs @@ -413,7 +413,7 @@ where let mut tx_index = first_tx_index .or(last_tx_idx) - .ok_or_else(|| ProviderError::BlockBodyIndicesNotFound(block_number))?; + .ok_or(ProviderError::BlockBodyIndicesNotFound(block_number))?; for tx in transactions.borrow() { self.static_file_mut().append_transaction(tx_index, tx)?; @@ -483,7 +483,7 @@ where let first_tx_index = first_tx_index .or(last_tx_idx) - .ok_or_else(|| ProviderError::BlockBodyIndicesNotFound(block_number))?; + .ok_or(ProviderError::BlockBodyIndicesNotFound(block_number))?; // update for empty blocks last_tx_idx = Some(first_tx_index); diff --git a/crates/storage/storage-api/src/transactions.rs b/crates/storage/storage-api/src/transactions.rs index 3685d6b1de..f2c44e9e14 100644 --- a/crates/storage/storage-api/src/transactions.rs +++ b/crates/storage/storage-api/src/transactions.rs @@ -89,12 +89,12 @@ pub trait TransactionsProviderExt: BlockReader + Send + Sync { ) -> ProviderResult> { let from = self .block_body_indices(*block_range.start())? - .ok_or(ProviderError::BlockBodyIndicesNotFound(*block_range.start()))? + .ok_or_else(|| ProviderError::BlockBodyIndicesNotFound(*block_range.start()))? .first_tx_num(); let to = self .block_body_indices(*block_range.end())? - .ok_or(ProviderError::BlockBodyIndicesNotFound(*block_range.end()))? + .ok_or_else(|| ProviderError::BlockBodyIndicesNotFound(*block_range.end()))? .last_tx_num(); Ok(from..=to)