From 826e387c87709b8d3f701f93063e6a607fca473f Mon Sep 17 00:00:00 2001
From: Georgios Konstantopoulos <me@gakonst.com>
Date: Tue, 17 Feb 2026 21:42:22 -0800
Subject: [PATCH] refactor(rpc): use ..Default::default() for SimCallResult
 initialization (#22309)

Co-authored-by: Amp <amp@ampcode.com>
---
 crates/rpc/rpc-eth-types/src/simulate.rs | 51 ++++++++++++++----------
 1 file changed, 29 insertions(+), 22 deletions(-)

diff --git a/crates/rpc/rpc-eth-types/src/simulate.rs b/crates/rpc/rpc-eth-types/src/simulate.rs
index 59d13a67c5..fdbbe13aae 100644
--- a/crates/rpc/rpc-eth-types/src/simulate.rs
+++ b/crates/rpc/rpc-eth-types/src/simulate.rs
@@ -367,6 +367,7 @@ where
                     gas_used,
                     logs: Vec::new(),
                     status: false,
+                    ..Default::default()
                 }
             }
             ExecutionResult::Revert { output, gas_used } => {
@@ -382,30 +383,36 @@ where
                     gas_used,
                     status: false,
                     logs: Vec::new(),
+                    ..Default::default()
+                }
+            }
+            ExecutionResult::Success { output, gas_used, logs, .. } =>
+            {
+                #[allow(clippy::needless_update)]
+                SimCallResult {
+                    return_data: output.into_data(),
+                    error: None,
+                    gas_used,
+                    logs: logs
+                        .into_iter()
+                        .map(|log| {
+                            log_index += 1;
+                            alloy_rpc_types_eth::Log {
+                                inner: log,
+                                log_index: Some(log_index - 1),
+                                transaction_index: Some(index as u64),
+                                transaction_hash: Some(*tx.tx_hash()),
+                                block_hash: Some(block.hash()),
+                                block_number: Some(block.header().number()),
+                                block_timestamp: Some(block.header().timestamp()),
+                                ..Default::default()
+                            }
+                        })
+                        .collect(),
+                    status: true,
+                    ..Default::default()
                 }
             }
-            ExecutionResult::Success { output, gas_used, logs, .. } => SimCallResult {
-                return_data: output.into_data(),
-                error: None,
-                gas_used,
-                logs: logs
-                    .into_iter()
-                    .map(|log| {
-                        log_index += 1;
-                        alloy_rpc_types_eth::Log {
-                            inner: log,
-                            log_index: Some(log_index - 1),
-                            transaction_index: Some(index as u64),
-                            transaction_hash: Some(*tx.tx_hash()),
-                            block_hash: Some(block.hash()),
-                            block_number: Some(block.header().number()),
-                            block_timestamp: Some(block.header().timestamp()),
-                            ..Default::default()
-                        }
-                    })
-                    .collect(),
-                status: true,
-            },
         };
 
         calls.push(call);