From 89bc38be1cb53fd02335a1ea36d71c4e97525902 Mon Sep 17 00:00:00 2001 From: Olivier Dupont Date: Mon, 16 Mar 2026 11:22:26 +0100 Subject: [PATCH] fix(rpc): remove redundant TransportRpcModuleConfig clone in builder (#22945) Co-authored-by: YK --- crates/rpc/rpc-builder/src/lib.rs | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/crates/rpc/rpc-builder/src/lib.rs b/crates/rpc/rpc-builder/src/lib.rs index a8435f6f2a..cee1daf459 100644 --- a/crates/rpc/rpc-builder/src/lib.rs +++ b/crates/rpc/rpc-builder/src/lib.rs @@ -394,20 +394,13 @@ where where EthApi: FullEthApiServer, { - let mut modules = TransportRpcModules::default(); - - if !module_config.is_empty() { - let TransportRpcModuleConfig { http, ws, ipc, config } = module_config.clone(); - - let mut registry = self.into_registry(config.unwrap_or_default(), eth, engine_events); - - modules.config = module_config; - modules.http = registry.maybe_module(http.as_ref()); - modules.ws = registry.maybe_module(ws.as_ref()); - modules.ipc = registry.maybe_module(ipc.as_ref()); + if module_config.is_empty() { + TransportRpcModules::default() + } else { + let config = module_config.config.clone().unwrap_or_default(); + let mut registry = self.into_registry(config, eth, engine_events); + registry.create_transport_rpc_modules(module_config) } - - modules } }