diff --git a/crates/revm/revm-inspectors/src/tracing/js/bindings.rs b/crates/revm/revm-inspectors/src/tracing/js/bindings.rs index a71720ef82..09f8b28fbd 100644 --- a/crates/revm/revm-inspectors/src/tracing/js/bindings.rs +++ b/crates/revm/revm-inspectors/src/tracing/js/bindings.rs @@ -491,7 +491,6 @@ pub(crate) struct EvmContext { pub(crate) output: Bytes, /// Number, block number pub(crate) time: String, - // TODO more fields pub(crate) block_hash: Option, pub(crate) tx_index: Option, pub(crate) tx_hash: Option, diff --git a/crates/revm/revm-inspectors/src/tracing/js/builtins.rs b/crates/revm/revm-inspectors/src/tracing/js/builtins.rs index bdba6945a6..88bfc2f9b1 100644 --- a/crates/revm/revm-inspectors/src/tracing/js/builtins.rs +++ b/crates/revm/revm-inspectors/src/tracing/js/builtins.rs @@ -16,6 +16,9 @@ use std::collections::HashSet; pub(crate) const BIG_INT_JS: &str = include_str!("bigint.js"); /// Registers all the builtin functions and global bigint property +/// +/// Note: this does not register the `isPrecompiled` builtin, as this requires the precompile +/// addresses, see [PrecompileList::register_callable]. pub(crate) fn register_builtins(ctx: &mut Context<'_>) -> JsResult<()> { let big_int = ctx.eval(Source::from_bytes(BIG_INT_JS.as_bytes()))?; ctx.register_global_property("bigint", big_int, Attribute::all())?; @@ -25,8 +28,6 @@ pub(crate) fn register_builtins(ctx: &mut Context<'_>) -> JsResult<()> { ctx.register_global_callable("toContract", 2, NativeFunction::from_fn_ptr(to_contract))?; ctx.register_global_callable("toContract2", 3, NativeFunction::from_fn_ptr(to_contract2))?; - // TODO: isPrecompiled slice - Ok(()) }