From a1d83dbbd3ac3e6fbfa1d7224aab85355f207087 Mon Sep 17 00:00:00 2001 From: Matthias Seitz Date: Fri, 20 Jan 2023 18:03:34 +0100 Subject: [PATCH] chore: prevent redundant hash initialization (#944) --- crates/primitives/src/transaction/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/primitives/src/transaction/mod.rs b/crates/primitives/src/transaction/mod.rs index 90efeedf0a..b6892a8ca1 100644 --- a/crates/primitives/src/transaction/mod.rs +++ b/crates/primitives/src/transaction/mod.rs @@ -685,9 +685,9 @@ impl Decodable for TransactionSigned { transaction.set_chain_id(id); } - let mut signed = TransactionSigned { transaction, hash: Default::default(), signature }; let tx_length = first_header.payload_length + first_header.length(); - signed.hash = keccak256(&original_encoding[..tx_length]); + let hash = keccak256(&original_encoding[..tx_length]); + let signed = TransactionSigned { transaction, hash, signature }; Ok(signed) } }