From a1e4132c2dd31b5d3130a4fa600c8742a0d5acbe Mon Sep 17 00:00:00 2001 From: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Tue, 17 Feb 2026 02:29:32 +0100 Subject: [PATCH] chore: reduce size of common spans (#22253) --- crates/engine/tree/src/tree/payload_processor/prewarm.rs | 2 +- crates/engine/tree/src/tree/payload_processor/sparse_trie.rs | 4 ++-- crates/storage/provider/src/providers/state/overlay.rs | 3 --- crates/trie/parallel/src/proof_task.rs | 2 +- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/crates/engine/tree/src/tree/payload_processor/prewarm.rs b/crates/engine/tree/src/tree/payload_processor/prewarm.rs index b27a10defc..097de8b67e 100644 --- a/crates/engine/tree/src/tree/payload_processor/prewarm.rs +++ b/crates/engine/tree/src/tree/payload_processor/prewarm.rs @@ -563,7 +563,7 @@ where let _enter = debug_span!( target: "engine::tree::payload_processor::prewarm", "prewarm tx", - index, + i=index, ) .entered(); diff --git a/crates/engine/tree/src/tree/payload_processor/sparse_trie.rs b/crates/engine/tree/src/tree/payload_processor/sparse_trie.rs index 4296da1b2e..2c6fc69530 100644 --- a/crates/engine/tree/src/tree/payload_processor/sparse_trie.rs +++ b/crates/engine/tree/src/tree/payload_processor/sparse_trie.rs @@ -332,7 +332,7 @@ where SparseTrieTaskMessage::PrefetchProofs(targets) } MultiProofMessage::StateUpdate(_, state) => { - let _span = debug_span!(target: "engine::tree::payload_processor::sparse_trie", "hashing state update", update_len = state.len()).entered(); + let _span = debug_span!(target: "engine::tree::payload_processor::sparse_trie", "hashing state update", n = state.len()).entered(); let hashed = evm_state_to_hashed_post_state(state); SparseTrieTaskMessage::HashedState(hashed) } @@ -652,7 +652,7 @@ where }) .par_bridge_buffered() .map(|(address, updates, mut fetched, mut trie)| { - let _enter = debug_span!(target: "engine::tree::payload_processor::sparse_trie", parent: &span, "storage trie leaf updates", ?address).entered(); + let _enter = debug_span!(target: "engine::tree::payload_processor::sparse_trie", parent: &span, "storage trie leaf updates", a=%address).entered(); let mut targets = Vec::new(); trie.update_leaves(updates, |path, min_len| match fetched.entry(path) { diff --git a/crates/storage/provider/src/providers/state/overlay.rs b/crates/storage/provider/src/providers/state/overlay.rs index 92bd6235dc..c7680c5336 100644 --- a/crates/storage/provider/src/providers/state/overlay.rs +++ b/crates/storage/provider/src/providers/state/overlay.rs @@ -458,9 +458,6 @@ where // Get a read-only provider let provider = { - let _guard = - debug_span!(target: "providers::state::overlay", "Creating db provider").entered(); - let start = Instant::now(); let res = self.factory.database_provider_ro()?; self.metrics.create_provider_duration.record(start.elapsed()); diff --git a/crates/trie/parallel/src/proof_task.rs b/crates/trie/parallel/src/proof_task.rs index c876f21833..0135ddea33 100644 --- a/crates/trie/parallel/src/proof_task.rs +++ b/crates/trie/parallel/src/proof_task.rs @@ -525,7 +525,7 @@ where let span = debug_span!( target: "trie::proof_task", "V2 Storage proof calculation", - targets = ?targets.len(), + n = %targets.len(), ); let _span_guard = span.enter();