From a808f7c22de79bbcf469e9115f1152c2cd84e26c Mon Sep 17 00:00:00 2001
From: Matthias Seitz <matthias.seitz@outlook.de>
Date: Thu, 10 Aug 2023 14:57:39 +0200
Subject: [PATCH] fix: omit output if empty (#4138)

---
 crates/revm/revm-inspectors/src/tracing/types.rs | 2 +-
 crates/rpc/rpc-types/src/eth/trace/geth/call.rs  | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/crates/revm/revm-inspectors/src/tracing/types.rs b/crates/revm/revm-inspectors/src/tracing/types.rs
index 51fb1d21cb..83a4586a4f 100644
--- a/crates/revm/revm-inspectors/src/tracing/types.rs
+++ b/crates/revm/revm-inspectors/src/tracing/types.rs
@@ -438,7 +438,7 @@ impl CallTraceNode {
             gas: U256::from(self.trace.gas_limit),
             gas_used: U256::from(self.trace.gas_used),
             input: self.trace.data.clone().into(),
-            output: Some(self.trace.output.clone().into()),
+            output: (!self.trace.output.is_empty()).then(|| self.trace.output.clone().into()),
             error: None,
             revert_reason: None,
             calls: Default::default(),
diff --git a/crates/rpc/rpc-types/src/eth/trace/geth/call.rs b/crates/rpc/rpc-types/src/eth/trace/geth/call.rs
index d131f0f6a3..c0391b0c9a 100644
--- a/crates/rpc/rpc-types/src/eth/trace/geth/call.rs
+++ b/crates/rpc/rpc-types/src/eth/trace/geth/call.rs
@@ -1,6 +1,8 @@
 use reth_primitives::{serde_helper::num::from_int_or_hex, Address, Bytes, H256, U256};
 use serde::{Deserialize, Serialize};
 
+/// The response object for `debug_traceTransaction` with `"tracer": "callTracer"`
+///
 /// <https://github.com/ethereum/go-ethereum/blob/91cb6f863a965481e51d5d9c0e5ccd54796fd967/eth/tracers/native/call.go#L44>
 #[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
 pub struct CallFrame {