From c132c6681af71248b1ea378eb6abd4f8cc55ab12 Mon Sep 17 00:00:00 2001 From: Matthias Seitz Date: Tue, 25 Apr 2023 17:09:37 +0200 Subject: [PATCH] fix(net): syncing should be true at startup (#2395) --- crates/net/network/src/network.rs | 2 +- crates/net/network/tests/it/startup.rs | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/crates/net/network/src/network.rs b/crates/net/network/src/network.rs index 2e20cf5e56..ad8868f7eb 100644 --- a/crates/net/network/src/network.rs +++ b/crates/net/network/src/network.rs @@ -57,7 +57,7 @@ impl NetworkHandle { peers, network_mode, bandwidth_meter, - is_syncing: Arc::new(Default::default()), + is_syncing: Arc::new(AtomicBool::new(true)), chain_id, }; Self { inner: Arc::new(inner) } diff --git a/crates/net/network/tests/it/startup.rs b/crates/net/network/tests/it/startup.rs index 024cdd1730..7366d32424 100644 --- a/crates/net/network/tests/it/startup.rs +++ b/crates/net/network/tests/it/startup.rs @@ -3,6 +3,7 @@ use reth_network::{ error::{NetworkError, ServiceKind}, Discovery, NetworkConfigBuilder, NetworkManager, }; +use reth_network_api::NetworkInfo; use reth_provider::test_utils::NoopProvider; use secp256k1::SecretKey; use std::{ @@ -19,6 +20,17 @@ fn is_addr_in_use_kind(err: NetworkError, kind: ServiceKind) -> bool { } } +#[tokio::test(flavor = "multi_thread")] +async fn test_is_default_syncing() { + let secret_key = SecretKey::new(&mut rand::thread_rng()); + let config = NetworkConfigBuilder::new(secret_key) + .disable_discovery() + .listener_port(0) + .build(NoopProvider::default()); + let network = NetworkManager::new(config).await.unwrap(); + assert!(network.handle().is_syncing()); +} + #[tokio::test(flavor = "multi_thread")] async fn test_listener_addr_in_use() { let secret_key = SecretKey::new(&mut rand::thread_rng());