From c41bdd9cbf3b1efafd07790a6b02bcab1a121879 Mon Sep 17 00:00:00 2001 From: Matthias Seitz Date: Sat, 21 Jan 2023 03:47:49 +0100 Subject: [PATCH] chore: prevent redundant hash initialization (#947) --- crates/primitives/src/transaction/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/primitives/src/transaction/mod.rs b/crates/primitives/src/transaction/mod.rs index b6892a8ca1..1d0cd60a5c 100644 --- a/crates/primitives/src/transaction/mod.rs +++ b/crates/primitives/src/transaction/mod.rs @@ -667,8 +667,8 @@ impl Decodable for TransactionSigned { s: Decodable::decode(buf)?, }; - let mut signed = TransactionSigned { transaction, hash: Default::default(), signature }; - signed.hash = keccak256(&original_encoding[..first_header.payload_length]); + let hash = keccak256(&original_encoding[..first_header.payload_length]); + let signed = TransactionSigned { transaction, hash, signature }; Ok(signed) } else { let mut transaction = Transaction::Legacy(TxLegacy {