From cd12ae58f23c06c2e610b81a40d0f8616521f19f Mon Sep 17 00:00:00 2001 From: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Fri, 30 Jan 2026 23:26:34 +0100 Subject: [PATCH] docs(CLAUDE.md): tweaks (#21646) --- CLAUDE.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index ca276aa4d0..0b3907dbd6 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -38,7 +38,7 @@ Reth is a high-performance Ethereum execution client written in Rust, focusing o 2. **Linting**: Run clippy with all features ```bash - RUSTFLAGS="-D warnings" cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features --locked + cargo +nightly clippy --workspace --lib --examples --tests --benches --all-features ``` 3. **Testing**: Use nextest for faster test execution @@ -169,12 +169,11 @@ Based on PR patterns, avoid: Before submitting changes, ensure: 1. **Format Check**: `cargo +nightly fmt --all --check` -2. **Clippy**: No warnings with `RUSTFLAGS="-D warnings"` +2. **Clippy**: No warnings 3. **Tests Pass**: All unit and integration tests 4. **Documentation**: Update relevant docs and add doc comments with `cargo docs --document-private-items` 5. **Commit Messages**: Follow conventional format (feat:, fix:, chore:, etc.) - ### Opening PRs against Label PRs appropriately, first check the available labels and then apply the relevant ones: @@ -349,10 +348,10 @@ Let's say you want to fix a bug where external IP resolution fails on startup: } ``` -5. **Run checks**: +5. **Run checks** (IMPORTANT!): ```bash cargo +nightly fmt --all - cargo clippy --all-features + cargo clippy --workspace --all-features # Make sure WHOLE WORKSPACE compiles! cargo test -p reth-discv4 ``` @@ -374,7 +373,7 @@ Let's say you want to fix a bug where external IP resolution fails on startup: cargo +nightly fmt --all # Run lints -RUSTFLAGS="-D warnings" cargo +nightly clippy --workspace --all-features --locked +cargo +nightly clippy --workspace --all-features # Run tests cargo nextest run --workspace