From d3d44fd46f03481ae0ab42adc5e6334ee64cd3b5 Mon Sep 17 00:00:00 2001 From: Thomas Coratger <60488569+tcoratger@users.noreply.github.com> Date: Tue, 27 Jun 2023 01:21:34 +0200 Subject: [PATCH] feat(cli): clean up log level features (#3414) --- .github/workflows/integration.yml | 4 ++-- bin/reth/Cargo.toml | 6 +++++- bin/reth/src/lib.rs | 8 ++++++-- 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 692d167e98..d4375665de 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -84,7 +84,7 @@ jobs: - name: Run sync (${{ matrix.profile }}) run: | - cargo run --profile release --features jemalloc,only-info-logs \ + cargo run --profile release --features jemalloc,min-error-logs \ --bin reth -- node \ --debug.tip 0x91c90676cab257a59cd956d7cb0bceb9b1a71d79755c23c7277a0697ccfaf8c4 \ --debug.max-block 100000 \ @@ -99,4 +99,4 @@ jobs: - name: Decide whether the needed jobs succeeded or failed uses: re-actors/alls-green@release/v1 with: - jobs: ${{ toJSON(needs) }} \ No newline at end of file + jobs: ${{ toJSON(needs) }} diff --git a/bin/reth/Cargo.toml b/bin/reth/Cargo.toml index c6b3560530..29470c9d1a 100644 --- a/bin/reth/Cargo.toml +++ b/bin/reth/Cargo.toml @@ -88,7 +88,11 @@ humantime = "2.1.0" [features] jemalloc = ["dep:jemallocator"] jemalloc-prof = ["jemalloc", "jemallocator?/profiling"] -only-info-logs = ["tracing/release_max_level_info"] +min-error-logs = ["tracing/release_max_level_error"] +min-warn-logs = ["tracing/release_max_level_warn"] +min-info-logs = ["tracing/release_max_level_info"] +min-debug-logs = ["tracing/release_max_level_debug"] +min-trace-logs = ["tracing/release_max_level_trace"] [build-dependencies] vergen = { version = "8.0.0", features = ["build", "cargo", "git", "gitcl"] } diff --git a/bin/reth/src/lib.rs b/bin/reth/src/lib.rs index 94a9408283..d42274e286 100644 --- a/bin/reth/src/lib.rs +++ b/bin/reth/src/lib.rs @@ -16,8 +16,12 @@ //! and leak detection functionality. See [jemalloc's opt.prof](https://jemalloc.net/jemalloc.3.html#opt.prof) //! documentation for usage details. This is **not recommended on Windows**. See [here](https://rust-lang.github.io/rfcs/1974-global-allocators.html#jemalloc) //! for more info. -//! - `only-info-logs`: Disables all logs below `info` level. This can speed up the node, since -//! fewer calls to the logging component is made. +//! - `min-error-logs`: Disables all logs below `error` level. +//! - `min-warn-logs`: Disables all logs below `warn` level. +//! - `min-info-logs`: Disables all logs below `info` level. This can speed up the node, since fewer +//! calls to the logging component is made. +//! - `min-debug-logs`: Disables all logs below `debug` level. +//! - `min-trace-logs`: Disables all logs below `trace` level. pub mod args; pub mod chain;