github/reth
1
1
Fork 0
mirror of https://github.com/paradigmxyz/reth.git synced 2026-04-30 03:01:58 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't mark ok tasks as panicked (#1359)

Browse Source
This commit is contained in:
Bjerg
2023-02-15 04:59:10 +01:00
committed by GitHub
parent d3817b1901
commit ddab623a46
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
crates/tasks/src/lib.rs
View File

@@ -11,7 +11,7 @@ use crate::shutdown::{signal, Shutdown, Signal};
use dyn_clone::DynClone;
use futures_util::{
future::{select, BoxFuture},
pin_mut, Future, FutureExt,
pin_mut, Future, FutureExt, TryFutureExt,
};
use std::{
pin::Pin,
@@ -262,7 +262,7 @@ impl TaskExecutor {
// wrap the task in catch unwind
let task = std::panic::AssertUnwindSafe(fut)
.catch_unwind()
.map(move |res| {
.inspect_err(move |res| {
error!("Critical task `{name}` panicked: {res:?}");
let _ = panicked_tasks_tx.send(name);
})
@@ -316,10 +316,11 @@ impl TaskExecutor {
// wrap the task in catch unwind
let task = std::panic::AssertUnwindSafe(fut)
.catch_unwind()
.map(move |res| {
.inspect_err(move |res| {
error!("Critical task `{name}` panicked: {res:?}");
let _ = panicked_tasks_tx.send(name);
})
.map(|_| ())
.in_current_span();
self.handle.spawn(task)