From f5cf90227b421ce396d62cd1adcbbd2c1577a17c Mon Sep 17 00:00:00 2001 From: Georgios Konstantopoulos Date: Sun, 15 Feb 2026 19:30:37 -0800 Subject: [PATCH] fix(net): fix flaky test_trusted_peer_only test (#22213) Co-authored-by: Amp --- crates/net/network/tests/it/connect.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/crates/net/network/tests/it/connect.rs b/crates/net/network/tests/it/connect.rs index a8d409ad69..ee70e8b369 100644 --- a/crates/net/network/tests/it/connect.rs +++ b/crates/net/network/tests/it/connect.rs @@ -12,7 +12,7 @@ use reth_network::{ }; use reth_network_api::{ events::{PeerEvent, SessionInfo}, - NetworkInfo, Peers, PeersInfo, + NetworkInfo, PeerKind, Peers, PeersInfo, }; use reth_network_p2p::{ headers::client::{HeadersClient, HeadersRequest}, @@ -423,6 +423,11 @@ async fn test_trusted_peer_only() { tokio::time::sleep(Duration::from_secs(1)).await; assert_eq!(handle.num_connected_peers(), 1); + // remove handle from handle1's peer list to prevent a competing outgoing connection attempt + // from handle1 racing with handle's outgoing connection below, which can cause duplicate + // session resolution to drop a connection + handle1.remove_peer(*handle.peer_id(), PeerKind::Basic); + handle.add_trusted_peer(*handle1.peer_id(), handle1.local_addr()); // wait for the next session established event to check the handle1 incoming connection