From fa05d19f1b225259500b49f46468f314a1070855 Mon Sep 17 00:00:00 2001 From: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Mon, 5 Jan 2026 18:58:20 +0100 Subject: [PATCH] fix(bench-compare): add backward compat for old CSV format (#20754) --- bin/reth-bench-compare/src/comparison.rs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/bin/reth-bench-compare/src/comparison.rs b/bin/reth-bench-compare/src/comparison.rs index 087ccaf3ce..0c9ffefb7c 100644 --- a/bin/reth-bench-compare/src/comparison.rs +++ b/bin/reth-bench-compare/src/comparison.rs @@ -39,7 +39,8 @@ pub(crate) struct BenchmarkResults { #[derive(Debug, Clone, Deserialize, Serialize)] pub(crate) struct CombinedLatencyRow { pub block_number: u64, - pub transaction_count: u64, + #[serde(default)] + pub transaction_count: Option, pub gas_used: u64, pub new_payload_latency: u128, } @@ -48,7 +49,8 @@ pub(crate) struct CombinedLatencyRow { #[derive(Debug, Clone, Deserialize, Serialize)] pub(crate) struct TotalGasRow { pub block_number: u64, - pub transaction_count: u64, + #[serde(default)] + pub transaction_count: Option, pub gas_used: u64, pub time: u128, } @@ -125,7 +127,8 @@ pub(crate) struct ComparisonSummary { #[derive(Debug, Serialize)] pub(crate) struct BlockComparison { pub block_number: u64, - pub transaction_count: u64, + #[serde(skip_serializing_if = "Option::is_none")] + pub transaction_count: Option, pub gas_used: u64, pub baseline_new_payload_latency: u128, pub feature_new_payload_latency: u128,