From 0894618814c93b20865452b2d9d2e7a967c4c23a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A9ter=20Garamv=C3=B6lgyi?= Date: Thu, 27 Nov 2025 16:01:39 +0100 Subject: [PATCH] comment fixes --- common/testcontainers/testcontainers.go | 4 ++-- rollup/internal/controller/sender/sender.go | 4 ++-- rollup/internal/controller/watcher/l1_watcher.go | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/common/testcontainers/testcontainers.go b/common/testcontainers/testcontainers.go index 23c66cf71..e2c224b25 100644 --- a/common/testcontainers/testcontainers.go +++ b/common/testcontainers/testcontainers.go @@ -167,7 +167,7 @@ func (t *TestcontainerApps) GetPoSL1EndPoint() (string, error) { return contrainer.PortEndpoint(context.Background(), "8545/tcp", "http") } -// GetPoSL1Client returns a ethclient by dialing running PoS L1 client +// GetPoSL1Client returns a raw rpc client and an ethclient by dialing the L1 node func (t *TestcontainerApps) GetPoSL1Client() (*rpc.Client, *ethclient.Client, error) { endpoint, err := t.GetPoSL1EndPoint() if err != nil { @@ -223,7 +223,7 @@ func (t *TestcontainerApps) GetGormDBClient() (*gorm.DB, error) { return database.InitDB(dbCfg) } -// GetL2GethClient returns a ethclient by dialing running L2Geth +// GetL2GethClient returns a raw rpc client and an ethclient by dialing the L2 node func (t *TestcontainerApps) GetL2GethClient() (*rpc.Client, *ethclient.Client, error) { rpcCli, err := t.GetL2Client() if err != nil { diff --git a/rollup/internal/controller/sender/sender.go b/rollup/internal/controller/sender/sender.go index ab1f5980f..282c8be58 100644 --- a/rollup/internal/controller/sender/sender.go +++ b/rollup/internal/controller/sender/sender.go @@ -841,9 +841,9 @@ func (s *Sender) getBlockNumberAndTimestampAndBaseFeeAndBlobFee(ctx context.Cont baseFee = header.BaseFee.Uint64() } - // Leave it up to the L1 node to return the correct blob base fee. + // Leave it up to the L1 node to compute the correct blob base fee. // Previously we would compute it locally using `CalcBlobFee`, but - // that needs to be in sync with the L1 node's configuration. + // that approach requires syncing any future L1 configuration changes. // Note: The fetched blob base fee might not correspond to the block // that we fetched in the previous step, but this is acceptable. var hex hexutil.Big diff --git a/rollup/internal/controller/watcher/l1_watcher.go b/rollup/internal/controller/watcher/l1_watcher.go index 510c36249..ed2b69e66 100644 --- a/rollup/internal/controller/watcher/l1_watcher.go +++ b/rollup/internal/controller/watcher/l1_watcher.go @@ -6,8 +6,8 @@ import ( "fmt" "math/big" - "github.com/ethereum/go-ethereum/common/hexutil" "github.com/prometheus/client_golang/prometheus" + "github.com/scroll-tech/go-ethereum/common/hexutil" gethTypes "github.com/scroll-tech/go-ethereum/core/types" "github.com/scroll-tech/go-ethereum/ethclient" "github.com/scroll-tech/go-ethereum/log" @@ -82,9 +82,9 @@ func (w *L1WatcherClient) FetchBlockHeader(blockHeight uint64) error { baseFee = block.BaseFee.Uint64() } - // Leave it up to the L1 node to return the correct blob base fee. + // Leave it up to the L1 node to compute the correct blob base fee. // Previously we would compute it locally using `CalcBlobFee`, but - // that needs to be in sync with the L1 node's configuration. + // that approach requires syncing any future L1 configuration changes. // Note: The fetched blob base fee might not correspond to the block // that we fetched in the previous step, but this is acceptable. var hex hexutil.Big