From 2b2cc62efe175fe092827e481d219d89f0092f69 Mon Sep 17 00:00:00 2001 From: colin <102356659+colinlyguo@users.noreply.github.com> Date: Wed, 12 Apr 2023 18:27:55 +0800 Subject: [PATCH] fix(coordinator): add metric roller_proofs_generated_failed_time (#419) --- common/version/version.go | 2 +- coordinator/manager.go | 1 + coordinator/roller_metrics.go | 11 +++++++++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/common/version/version.go b/common/version/version.go index df8616eb6..a811fa3f3 100644 --- a/common/version/version.go +++ b/common/version/version.go @@ -5,7 +5,7 @@ import ( "runtime/debug" ) -var tag = "v3.0.9" +var tag = "v3.0.10" var commit = func() string { if info, ok := debug.ReadBuildInfo(); ok { diff --git a/coordinator/manager.go b/coordinator/manager.go index 87b54d345..e0e68e2b4 100644 --- a/coordinator/manager.go +++ b/coordinator/manager.go @@ -299,6 +299,7 @@ func (m *Manager) handleZkProof(pk string, msg *message.ProofDetail) error { if msg.Status != message.StatusOk { coordinatorProofsGeneratedFailedTimeTimer.Update(proofTime) + m.updateMetricRollerProofsGeneratedFailedTimeTimer(roller.PublicKey, proofTime) log.Info( "proof generated by roller failed", "proof id", msg.ID, diff --git a/coordinator/roller_metrics.go b/coordinator/roller_metrics.go index cfdacf28f..62c8ea3c8 100644 --- a/coordinator/roller_metrics.go +++ b/coordinator/roller_metrics.go @@ -58,3 +58,14 @@ func (m *Manager) updateMetricRollerProofsVerifiedFailedTimeTimer(pk string, d t } } } + +func (m *Manager) updateMetricRollerProofsGeneratedFailedTimeTimer(pk string, d time.Duration) { + if node, ok := m.rollerPool.Get(pk); ok { + rMs := node.(*rollerNode).rollerMetrics + if rMs != nil { + rMs.rollerProofsGeneratedFailedTimeTimer.Update(d) + } else { + log.Error("rollerProofsGeneratedFailedTimeTimer is nil", "roller pk", pk) + } + } +}