From e5e5cafc48813ca6f777fc58f3f7f376b7da833f Mon Sep 17 00:00:00 2001 From: colin <102356659+colinlyguo@users.noreply.github.com> Date: Mon, 19 Feb 2024 09:45:09 +0800 Subject: [PATCH] fix(sender): nil pointer panic when resubmitting failure (#1133) Co-authored-by: colinlyguo --- common/version/version.go | 2 +- rollup/internal/controller/sender/sender.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/version/version.go b/common/version/version.go index 6d2a8e70f..e5bfe75a7 100644 --- a/common/version/version.go +++ b/common/version/version.go @@ -5,7 +5,7 @@ import ( "runtime/debug" ) -var tag = "v4.3.63" +var tag = "v4.3.64" var commit = func() string { if info, ok := debug.ReadBuildInfo(); ok { diff --git a/rollup/internal/controller/sender/sender.go b/rollup/internal/controller/sender/sender.go index b1c326271..196e58e62 100644 --- a/rollup/internal/controller/sender/sender.go +++ b/rollup/internal/controller/sender/sender.go @@ -472,7 +472,7 @@ func (s *Sender) checkPendingTransaction() { if newTx, err := s.resubmitTransaction(tx, baseFee); err != nil { s.metrics.resubmitTransactionFailedTotal.WithLabelValues(s.service, s.name).Inc() - log.Error("failed to resubmit transaction", "context ID", txnToCheck.ContextID, "sender meta", s.getSenderMeta(), "from", s.auth.From.String(), "nonce", newTx.Nonce(), "err", err) + log.Error("failed to resubmit transaction", "context ID", txnToCheck.ContextID, "sender meta", s.getSenderMeta(), "from", s.auth.From.String(), "nonce", tx.Nonce(), "err", err) } else { err := s.db.Transaction(func(dbTX *gorm.DB) error { // Update the status of the original transaction as replaced, while still checking its confirmation status.