Xi Lin
e6db4ac3a8
feat(contracts): make sure prover and sequencer is EOA ( #1002 )
2023-11-03 12:21:20 -07:00
Xi Lin
ff380141a8
feat(contracts): update ScrollOwner initialization script ( #987 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-10-12 08:51:20 +02:00
HAOYUatHZ
2216ad4271
refactor: remove rpc-gateway submodule ( #985 )
2023-10-11 16:57:41 +08:00
Xi Lin
7c742da488
feat(contracts): add emergency role to pause L1/L2ScrollMessenger ( #975 )
...
Co-authored-by: Péter Garamvölgyi <peter@scroll.io >
2023-10-07 11:33:09 +02:00
Péter Garamvölgyi
0cdb0dc7a9
feat: remove DAI gateway from deployment script ( #979 )
2023-10-06 18:03:21 +02:00
Xi Lin
3143373f5f
feat(contracts): remove rate limiter related codes ( #978 )
2023-10-05 21:16:01 +02:00
Xi Lin
05da46a719
test(contracts): OZ-L01 Insufficient Tests When Using BitMaps ( #956 )
...
Co-authored-by: Haichen Shen <shenhaichen@gmail.com >
2023-10-04 15:59:53 -07:00
Xi Lin
55e0b11d17
fix(contracts): OZ-N03 Inconsistent Usage of msg.sender ( #906 )
2023-10-04 15:45:17 -07:00
Xi Lin
4d903bc9b2
feat(contracts): foundry scripts for ScrollOwner ( #838 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: Péter Garamvölgyi <peter@scroll.io >
Co-authored-by: Haichen Shen <shenhaichen@gmail.com >
2023-09-21 17:45:24 +02:00
Xi Lin
0e12661fd5
docs(contracts): OZ-N01 Misleading Documentation ( #955 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-21 12:37:56 +08:00
Xi Lin
04e66231e5
fix(contracts): OZ-L02 Implicit Limitation of Withdrawal ( #954 )
2023-09-20 12:18:19 +02:00
Xi Lin
417a228523
fix(contracts): OZ-L03 Inconsistency of Allowing a Trusted Forwarder ( #846 )
...
Co-authored-by: Haichen Shen <shenhaichen@gmail.com >
2023-09-19 14:50:21 -07:00
Xi Lin
ae95e61902
fix(contracts): OZ-M01 Lack of Expiration for Retrying Transactions ( #840 )
...
Co-authored-by: Haichen Shen <shenhaichen@gmail.com >
Co-authored-by: icemelon <icemelon@users.noreply.github.com >
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
2023-09-13 12:49:08 -07:00
dependabot[bot]
f21d4adbfd
build(deps): bump @openzeppelin/contracts-upgradeable from 4.9.2 to 4.9.3 in /contracts ( #935 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xi Lin <zimpha@gmail.com >
2023-09-13 09:48:48 +02:00
Xi Lin
145edfccb9
refactor(contracts): merge FeeVault and L2TxFeeVault ( #943 )
2023-09-13 09:36:53 +02:00
dependabot[bot]
6f26114f23
build(deps): bump @openzeppelin/contracts from 4.9.2 to 4.9.3 in /contracts ( #936 )
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-12 10:38:01 +08:00
Xi Lin
56150da353
docs(contracts): OZ-L03 Missing Docstrings ( #940 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-12 10:27:54 +08:00
Péter Garamvölgyi
fc53572334
fix: mark used storage slots in L2ScrollMessenger ( #941 )
2023-09-11 15:35:18 +02:00
Xi Lin
4d3ff66446
fix(contracts): OZ-L02 Lack of gap Variable ( #929 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-11 11:06:09 +08:00
Xi Lin
ae1cb30ed1
fix(contracts): OZ-M01 L2USDCGateway Is Missing Rate Limiter Functionality ( #927 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-11 10:47:14 +08:00
Xi Lin
ad14836796
fix(contracts): Zellic 3.2 Addtional checks could be performed ( #892 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-11 10:36:54 +08:00
Xi Lin
7559dc42b4
feat(contacts): use bitmap for skipped messages ( #893 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
2023-09-07 14:31:06 +08:00
Xi Lin
0b0b84a513
fix(contracts): OZ-N01 Unused Imports ( #930 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-06 13:34:29 +08:00
Xi Lin
e35de74495
docs(contracts): OZ-L01 Misleading Comment ( #928 )
2023-09-06 11:59:35 +08:00
Péter Garamvölgyi
c71fa5a5fc
style: use MAX_TX_IN_CHUNK env name in deployment scripts ( #921 )
2023-09-04 14:35:04 +02:00
Péter Garamvölgyi
4af3834e36
test(fee-vault): add new test testCantWithdrawMoreThanBalance ( #918 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-04 08:15:26 +02:00
Xi Lin
d288b34536
fix(contracts): OZ-L02 Anyone Can Steal ERC-20 Tokens From GasSwap ( #844 )
...
Co-authored-by: Haichen Shen <shenhaichen@gmail.com >
Co-authored-by: icemelon <icemelon@users.noreply.github.com >
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
2023-09-04 12:31:41 +08:00
Péter Garamvölgyi
8699a22fa3
feat(contracts): allow setting withdraw amount in fee vault ( #912 )
...
Co-authored-by: Haichen Shen <shenhaichen@gmail.com >
2023-09-02 02:23:53 -07:00
Xi Lin
d668180e9a
fix(contracts): OZ-M04 Use of Non-Production-Ready Trusted Forwarder ( #843 )
...
Co-authored-by: Haichen Shen <shenhaichen@gmail.com >
Co-authored-by: icemelon <icemelon@users.noreply.github.com >
2023-09-02 02:23:31 -07:00
Haichen Shen
38b440b1fa
docs(contract): Update readme ( #378 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
Co-authored-by: Orest Tarasiuk <830847+OrestTa@users.noreply.github.com >
Co-authored-by: Péter Garamvölgyi <peter@scroll.io >
2023-09-01 20:22:09 -07:00
Xi Lin
a7d9bf3488
fix(contracts): OZ-N05 Lack of Logs on Sensitive Actions ( #908 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-01 22:55:11 +08:00
Xi Lin
255eb5f307
fix(contracts): OZ-L02 Utilizing Deprecated Function From Library ( #902 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-01 22:42:20 +08:00
Xi Lin
07961f751e
fix(contracts): OZ-N01 Variable Cast is Unnecessary ( #903 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-01 22:18:17 +08:00
Xi Lin
bbd5a5a9c2
fix(contracts): OZ-N02 Incorrect Function Visibility ( #904 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-01 21:58:47 +08:00
Xi Lin
2e1f42fcb6
fix(contracts): OZ-N04 Implicit Type Casting ( #907 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-01 19:45:35 +08:00
Xi Lin
bcdbe1f119
fix(contracts): OZ-N07 Naming Issue ( #910 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-09-01 19:29:57 +08:00
Xi Lin
6034c43bb1
fix(contracts): OZ-N06 Unpinned Compiler Version ( #909 )
2023-09-01 19:20:10 +08:00
Xi Lin
38f64e70b7
feat(contracts): bench test for ScrollChain ( #721 )
...
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com >
Co-authored-by: Haichen Shen <shenhaichen@gmail.com >
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: icemelon <icemelon@users.noreply.github.com >
2023-08-31 23:52:50 -07:00
Xi Lin
8daa5d5496
fix(contracts): check actual number of transactions in each chunk ( #887 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
2023-08-31 20:28:54 -07:00
Xi Lin
f6894bb82f
feat(contracts): add usdc gateway ( #426 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: Haichen Shen <shenhaichen@gmail.com >
2023-08-29 00:28:29 -07:00
Xi Lin
fecd129a39
fix(contracts): OZ-L08 Redundancy of Replaying Messages in L2ScrollMessenger ( #850 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-08-25 16:25:52 +08:00
Xi Lin
663156984f
fix(contracts): OZ-N08 Inconsistent Order of Event Emissions ( #876 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-08-25 15:51:52 +08:00
Xi Lin
3499c595e7
fix(contracts): OZ-N07 Incorrect Function Visibility ( #875 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-08-25 15:03:15 +08:00
Xi Lin
95d2df46e3
fix(contracts): OZ-N14 Duplicate Imports ( #877 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com >
2023-08-25 14:21:59 +08:00
Xi Lin
102d29c54d
docs(contracts): OZ-N06 Inconsistent Coding Style ( #874 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
2023-08-25 11:59:20 +08:00
Xi Lin
7d50699344
fix(contracts): OZ-L07 Potentially Misleading Verifier Event ( #849 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-08-25 10:45:35 +08:00
Xi Lin
e08b800d1d
fix(contracts): OZ-L06 Possible Misleading revert Message When Swapping Non-ERC20Permit Tokens ( #847 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
2023-08-25 10:23:02 +08:00
Xi Lin
6139ca0df0
fix(contracts): OZ-L10 maxReplayTimes is Not Initialized in L1ScrollMessenger ( #852 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com >
Co-authored-by: HAOYUatHZ <HAOYUatHZ@users.noreply.github.com >
2023-08-25 10:10:31 +08:00
Xi Lin
d7d62eb8e6
docs(contracts): OZ-L09 Misleading and Incorrect Comments ( #851 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
2023-08-22 12:53:42 +08:00
Xi Lin
ae2e010324
feat(contracts): add rate limiter ( #712 )
...
Co-authored-by: zimpha <zimpha@users.noreply.github.com >
2023-08-18 06:43:58 -07:00