github/self
1
1
Fork 0
mirror of https://github.com/selfxyz/self.git synced 2026-04-05 03:00:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: minor fixes across monorepo (#1068)

Browse Source 
* small fixes

* fixes

* fix gesture handler error

* ci fixes
This commit is contained in:
Justin Hernandez
2025-09-13 17:55:35 -07:00
committed by GitHub
parent 657d8af96e
commit 5c569e6334
10 changed files with 105 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/src/screens/dev/CreateMockScreen.tsx
View File

@@ -5,7 +5,7 @@
import { flag } from 'country-emoji';
import getCountryISO2 from 'country-iso-3-to-2';
import React, { useCallback, useState } from 'react';
import { TouchableOpacity } from 'react-native';
import { TouchableOpacity, View } from 'react-native';
import { Gesture, GestureDetector } from 'react-native-gesture-handler';
import { useSafeAreaInsets } from 'react-native-safe-area-context';
import {
@@ -223,7 +223,9 @@ const CreateMockScreen: React.FC = () => {
>
<ScrollView showsVerticalScrollIndicator={false}>
<GestureDetector gesture={devModeTap}>
<HeroBanner />
<View collapsable={false}>
<HeroBanner />
</View>
</GestureDetector>
<YStack paddingHorizontal="$4" paddingBottom="$4" gap="$4">
<Text fontWeight={500} fontSize="$6" fontFamily={dinot}>

29
app/src/screens/document/DocumentNFCScanScreen.tsx
View File

@@ -10,6 +10,7 @@ import {
NativeModules,
Platform,
StyleSheet,
View,
} from 'react-native';
import { Gesture, GestureDetector } from 'react-native-gesture-handler';
import NfcManager from 'react-native-nfc-manager';
@@ -627,19 +628,21 @@ const DocumentNFCScanScreen: React.FC = () => {
<>
<TextsContainer>
<GestureDetector gesture={devModeTap}>
<XStack
justifyContent="space-between"
alignItems="center"
gap="$1.5"
>
<Title>Verify your ID</Title>
<Button
unstyled
onPress={goToNFCTrouble}
icon={<CircleHelp size={28} color={slate500} />}
aria-label="Help"
/>
</XStack>
<View collapsable={false}>
<XStack
justifyContent="space-between"
alignItems="center"
gap="$1.5"
>
<Title>Verify your ID</Title>
<Button
unstyled
onPress={goToNFCTrouble}
icon={<CircleHelp size={28} color={slate500} />}
aria-label="Help"
/>
</XStack>
</View>
</GestureDetector>
{isNfcEnabled ? (
<>

9
app/src/screens/document/DocumentNFCTroubleScreen.tsx
View File

@@ -3,6 +3,7 @@
// NOTE: Converts to Apache-2.0 on 2029-06-11 per LICENSE.
import React, { useEffect } from 'react';
import { View } from 'react-native';
import { Gesture, GestureDetector } from 'react-native-gesture-handler';
import { YStack } from 'tamagui';
@@ -93,9 +94,11 @@ const DocumentNFCTroubleScreen: React.FC = () => {
gap={20}
>
<GestureDetector gesture={devModeTap}>
<Caption size="large" color={slate500}>
Here are some tips to help you successfully scan the RFID chip:
</Caption>
<View collapsable={false}>
<Caption size="large" color={slate500}>
Here are some tips to help you successfully scan the RFID chip:
</Caption>
</View>
</GestureDetector>
<Tips items={tips} />
<Caption size="large" color={slate500}>

120
app/src/screens/settings/SettingsScreen.tsx
View File

@@ -4,7 +4,7 @@
import type { PropsWithChildren } from 'react';
import React, { useCallback, useMemo } from 'react';
import { Linking, Platform, Share } from 'react-native';
import { Linking, Platform, Share, View as RNView } from 'react-native';
import { Gesture, GestureDetector } from 'react-native-gesture-handler';
import { useSafeAreaInsets } from 'react-native-safe-area-context';
import type { SvgProps } from 'react-native-svg';
@@ -212,70 +212,72 @@ ${deviceInfo.map(([k, v]) => `${k}=${v}`).join('; ')}
const { bottom } = useSafeAreaInsets();
return (
<GestureDetector gesture={devModeTap}>
<View backgroundColor={white}>
<YStack
backgroundColor={black}
gap={20}
justifyContent="space-between"
height={'100%'}
paddingHorizontal={20}
paddingBottom={bottom + extraYPadding}
borderTopLeftRadius={30}
borderTopRightRadius={30}
>
<ScrollView>
<YStack
alignItems="flex-start"
justifyContent="flex-start"
width="100%"
>
{screenRoutes.map(([Icon, menuText, menuRoute]) => (
<MenuButton
key={menuRoute}
Icon={Icon}
onPress={onMenuPress(menuRoute)}
>
{menuText}
</MenuButton>
))}
</YStack>
</ScrollView>
<RNView collapsable={false}>
<View backgroundColor={white}>
<YStack
alignItems="center"
backgroundColor={black}
gap={20}
justifyContent="center"
paddingBottom={50}
justifyContent="space-between"
height={'100%'}
paddingHorizontal={20}
paddingBottom={bottom + extraYPadding}
borderTopLeftRadius={30}
borderTopRightRadius={30}
>
<Button
unstyled
icon={<Star color={white} height={24} width={21} />}
width="100%"
padding={20}
backgroundColor={slate800}
color={white}
flexDirection="row"
justifyContent="center"
<ScrollView>
<YStack
alignItems="flex-start"
justifyContent="flex-start"
width="100%"
>
{screenRoutes.map(([Icon, menuText, menuRoute]) => (
<MenuButton
key={menuRoute}
Icon={Icon}
onPress={onMenuPress(menuRoute)}
>
{menuText}
</MenuButton>
))}
</YStack>
</ScrollView>
<YStack
alignItems="center"
gap={6}
borderRadius={4}
pressStyle={pressedStyle}
onPress={goToStore}
gap={20}
justifyContent="center"
paddingBottom={50}
>
<BodyText color={white}>Leave an app store review</BodyText>
</Button>
<XStack gap={32}>
{social.map(([Icon, href], i) => (
<SocialButton key={i} Icon={Icon} href={href} />
))}
</XStack>
<BodyText color={amber500} fontSize={15}>
SELF
</BodyText>
{/* Dont remove if not viewing on ios */}
<View marginBottom={bottom} />
<Button
unstyled
icon={<Star color={white} height={24} width={21} />}
width="100%"
padding={20}
backgroundColor={slate800}
color={white}
flexDirection="row"
justifyContent="center"
alignItems="center"
gap={6}
borderRadius={4}
pressStyle={pressedStyle}
onPress={goToStore}
>
<BodyText color={white}>Leave an app store review</BodyText>
</Button>
<XStack gap={32}>
{social.map(([Icon, href], i) => (
<SocialButton key={i} Icon={Icon} href={href} />
))}
</XStack>
<BodyText color={amber500} fontSize={15}>
SELF
</BodyText>
{/* Dont remove if not viewing on ios */}
<View marginBottom={bottom} />
</YStack>
</YStack>
</YStack>
</View>
</View>
</RNView>
</GestureDetector>
);
};