From f7b1ccef9c4ad660d72c167435c7aacb34921ed4 Mon Sep 17 00:00:00 2001 From: Javier Cortejoso Date: Wed, 11 Feb 2026 18:14:19 +0100 Subject: [PATCH] chore: refine npm publish workflow by removing strict mode input - Eliminated the 'strict_mode' input from the npm publish workflow to simplify the process. - Removed associated error handling comments and environment variable for stricter publish mode. - Streamlined the workflow for improved clarity and efficiency during package publishing. --- .github/workflows/npm-publish.yml | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml index 85126535c..2afe6a7c6 100644 --- a/.github/workflows/npm-publish.yml +++ b/.github/workflows/npm-publish.yml @@ -13,11 +13,6 @@ on: - "contracts/package.json" workflow_dispatch: inputs: - strict_mode: - description: "Fail workflow on publish errors (false = continue on error)" - required: false - type: boolean - default: false dry_run: description: "Run publish with --dry-run (validates auth/Trusted Publishers without uploading)" required: false @@ -28,15 +23,6 @@ permissions: id-token: write # Required for OIDC contents: read -# Error Handling Strategy: -# - STRICT_PUBLISH_MODE controls whether publish failures stop the workflow -# - Current (false): continue-on-error=true, workflow always succeeds -# - Target (true): continue-on-error=false, fail on real errors (expired tokens, network issues) -# - Manual override: Use workflow_dispatch with strict_mode input to test -# TODO: Set STRICT_PUBLISH_MODE=true once NPM token is rotated and verified -env: - STRICT_PUBLISH_MODE: false - jobs: detect-changes: runs-on: ubuntu-slim @@ -108,7 +94,6 @@ jobs: - name: Publish to npm working-directory: sdk/core - continue-on-error: ${{ github.event.inputs.strict_mode != 'true' && env.STRICT_PUBLISH_MODE != 'true' }} id: publish run: | yarn config set npmPublishAccess public @@ -148,7 +133,6 @@ jobs: - name: Publish to npm working-directory: sdk/qrcode - continue-on-error: ${{ github.event.inputs.strict_mode != 'true' && env.STRICT_PUBLISH_MODE != 'true' }} id: publish run: | yarn config set npmPublishAccess public @@ -186,7 +170,6 @@ jobs: - name: Publish to npm working-directory: common - continue-on-error: ${{ github.event.inputs.strict_mode != 'true' && env.STRICT_PUBLISH_MODE != 'true' }} id: publish run: | yarn config set npmPublishAccess public @@ -221,7 +204,6 @@ jobs: yarn workspace @selfxyz/contracts build - name: Publish to npm working-directory: contracts - continue-on-error: ${{ github.event.inputs.strict_mode != 'true' && env.STRICT_PUBLISH_MODE != 'true' }} id: publish run: | yarn config set npmPublishAccess public @@ -259,7 +241,6 @@ jobs: - name: Publish to npm working-directory: sdk/qrcode-angular - continue-on-error: ${{ github.event.inputs.strict_mode != 'true' && env.STRICT_PUBLISH_MODE != 'true' }} id: publish run: | yarn config set npmPublishAccess public @@ -299,7 +280,6 @@ jobs: - name: Publish to npm working-directory: packages/mobile-sdk-alpha - continue-on-error: ${{ github.event.inputs.strict_mode != 'true' && env.STRICT_PUBLISH_MODE != 'true' }} id: publish run: | yarn config set npmPublishAccess restricted