* feat: expose MRZ parsing on client * feat: add SelfClient provider * feat: add react native entry * feat: add mobile sdk entry wrapper * upgrade packages * save wip * clean up tests to support new arch * abstract SelfMobileSdk * pr feedback * updates * pr updates * update lock * updates * fix types * updates * fix tests * test: verify provider memoization and add jsdoc (#929) * pr feedback
6.5 KiB
PR {{PR_NUMBER}} Action Items
Overview
Title: {{PR_TITLE}} Author: {{AUTHOR}} Status: {{STATUS}} Created: {{DATE}} Branch: {{BRANCH}}
{{PR_SUMMARY}}
Analysis Summary
After thorough review of all {{TOTAL_COMMENTS}} CodeRabbit comments, ALL issues have been resolved in subsequent commits. The PR is ready for merge.
Resolved Comments ✅ ({{TOTAL_COMMENTS}}/{{TOTAL_COMMENTS}})
All comments show ✅ "Addressed" status, indicating they were fixed in commits:
- {{RESOLVED_CATEGORY_1}} - Fixed in commits {{COMMIT_RANGE}}
- {{RESOLVED_CATEGORY_2}} - Fixed in commits {{COMMIT_RANGE}}
Unresolved Comments 🔴 (0/{{TOTAL_COMMENTS}})
None - All comments have been addressed.
Conclusion
This PR is ready for merge. All CodeRabbit issues have been resolved.
Critical Issues (Blocking Merge)
1. {{ISSUE_TITLE}}
Files: {{FILE_PATH}}:{{LINE_NUMBER}}
CodeRabbit Comment: {{COMMENT_ID}}
Problem: {{PROBLEM_DESCRIPTION}}
Fix: {{SPECIFIC_FIX_OR_ACTION}}
Code Example:
{{CODE_EXAMPLE}}
2. {{ISSUE_TITLE}}
Files: {{FILE_PATH}}:{{LINE_NUMBER}}
CodeRabbit Comment: {{COMMENT_ID}}
Problem: {{PROBLEM_DESCRIPTION}}
Fix: {{SPECIFIC_FIX_OR_ACTION}}
Required Actions
Issue 1: {{GROUPED_ISSUE_TITLE}}
Root Cause: {{ROOT_CAUSE_DESCRIPTION}} Files Affected:
{{FILE_PATH}}:{{LINE_NUMBER}}- {{ISSUE_DESCRIPTION}}{{FILE_PATH}}:{{LINE_NUMBER}}- {{ISSUE_DESCRIPTION}}
Actions:
- {{SPECIFIC_ACTION_1}}
- {{SPECIFIC_ACTION_2}}
- {{SPECIFIC_ACTION_3}}
Code Example:
{{CODE_EXAMPLE}}
Issue 2: {{GROUPED_ISSUE_TITLE}}
Root Cause: {{ROOT_CAUSE_DESCRIPTION}} Files Affected:
{{FILE_PATH}}:{{LINE_NUMBER}}- {{ISSUE_DESCRIPTION}}
Actions:
- {{SPECIFIC_ACTION_1}}
- {{SPECIFIC_ACTION_2}}
CodeRabbit Analysis Summary
Resolved Comments ✅
- {{RESOLVED_COMMENT_1}}
- {{RESOLVED_COMMENT_2}}
Unresolved Comments 🔴
- {{UNRESOLVED_COMMENT_1}} - {{STATUS}}
- {{UNRESOLVED_COMMENT_2}} - {{STATUS}}
Comment Categories
- Critical: {{COUNT}} comments (React Native compatibility, security, memory leaks)
- Architecture: {{COUNT}} comments (API design, type safety)
- Code Quality: {{COUNT}} comments (testing, imports, documentation)
Testing Checklist
Before Merge
- {{SPECIFIC_TEST_TO_RUN}}
- {{SPECIFIC_VALIDATION}}
- {{SPECIFIC_BUILD_TEST}}
Post-Merge
- {{INTEGRATION_TEST}}
- {{PERFORMANCE_TEST}}
Breaking Changes
For Consumers
- {{SPECIFIC_BREAKING_CHANGE}}
- {{MIGRATION_NEEDED}}
Migration Guide
- Update import statements
- Replace deprecated API calls
- Handle new dependencies
Implementation Priority
Phase 1: Critical Fixes (Blocking Merge)
- {{CRITICAL_FIX_1}}
- {{CRITICAL_FIX_2}}
Phase 2: Architecture Improvements
- {{ARCHITECTURE_FIX_1}}
- {{ARCHITECTURE_FIX_2}}
Phase 3: Polish & Documentation
- {{POLISH_ITEM_1}}
- {{POLISH_ITEM_2}}
Notes
- {{SPECIFIC_NOTE_1}}
- {{SPECIFIC_NOTE_2}}
- {{SPECIFIC_NOTE_3}}
Agent Verification Checklist
BEFORE FINALIZING - VERIFY EACH ITEM:
- ✅ Read ALL {{TOTAL_COMMENTS}} CodeRabbit comments thoroughly
- ✅ Checked each comment for "✅ Addressed" status
- ✅ Excluded all nitpick/style/documentation-only suggestions
- ✅ Only included MEDIUM+ severity issues (security, architecture, functionality)
- ✅ Verified unresolved count is accurate
- ✅ If 0 unresolved issues, used "All issues resolved" template
- ✅ Double-checked that each "unresolved" issue is actually unresolved
SEVERITY VERIFICATION:
- ✅ CRITICAL: Security, memory leaks, platform compatibility ({{CRITICAL_COUNT}})
- ✅ HIGH: API inconsistencies, type safety, architecture ({{HIGH_COUNT}})
- ✅ MEDIUM: Test coverage, performance, minor architecture ({{MEDIUM_COUNT}})
- ❌ LOW/NITPICK: Style, naming, docs (EXCLUDED - {{EXCLUDED_COUNT}})
Last Updated: {{DATE}} CodeRabbit Comments Analyzed: {{TOTAL_COMMENTS}} Unresolved Medium+ Issues: {{UNRESOLVED_COUNT}} Excluded Low/Nitpick Issues: {{EXCLUDED_COUNT}}