mirror of
https://github.com/selfxyz/self.git
synced 2026-02-19 02:24:25 -05:00
* Update dependency versions * Fix gesture handler Android dependency (#1611) * Patch screens codegen type (#1609) * Downgrade Sentry React Native (#1612) * fix patches and packages * downgrade versions for gesture handler and screens * agent feedback * fix ios building * allow ios tets to pass * formatting * make cache more resilient * Address CodeRabbitAI review comments This commit addresses all 7 unresolved CodeRabbitAI comments on PR #1606: Patch-package error handling (comments #1, #2, #3): - stderr capture already implemented in both root and workspace patch runs - Add CI warning when patches fail silently instead of exiting with 0 - Log completion status in CI mode for visibility Critical Mixpanel dependency fix (comment #5): - Add explicit Mixpanel-swift pod declaration to fix E2E build failures - Ensures Mixpanel is available even when NFCPassportReader is skipped during E2E testing React-native-web validation (comment #4): - Verified no usage of deprecated findNodeHandle, pointerEvents: 'box-none', or createPortal - Safe to upgrade from 0.19 to 0.21.2 CI workflow improvements (comments #6, #7): - Create cache-sdk-build composite action for consistent SDK build artifact caching - Replace all direct actions/cache@v4 usage with cache-yarn composite action - Replace all direct actions/cache/restore@v4 and save@v4 with cache-sdk-build - Add nested require() validation step before tests to fail fast on problematic patterns All changes follow repository coding guidelines for CI caching and test memory optimization. * Extend cache composite actions to all SDK workflows This commit extends the caching standardization from PR #1606 to include mobile-sdk-ci.yml and core-sdk-ci.yml workflows. New composite actions created: - cache-mobile-sdk-build: For mobile SDK build artifacts - cache-core-sdk-build: For core SDK build artifacts Workflow updates: - mobile-sdk-ci.yml: Replaced 5 instances of direct actions/cache with cache-mobile-sdk-build - core-sdk-ci.yml: Replaced 4 instances of direct actions/cache with cache-core-sdk-build All SDK CI workflows now use consistent caching patterns via composite actions, following the AGENTS.md guideline: "Use shared composite actions from .github/actions for CI caching instead of calling actions/cache directly." Benefits: - Consistent caching across all SDK workflows (qrcode, mobile, core) - Centralized cache configuration - easier to maintain - Follows established patterns from qrcode-sdk-ci.yml * downgrade react-native-svg * update pod lock file * sort
184 lines
6.2 KiB
JavaScript
184 lines
6.2 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { spawnSync } = require('child_process');
|
|
|
|
const repositoryRootPath = path.resolve(__dirname, '..');
|
|
const patchesDirectoryPath = path.join(repositoryRootPath, 'patches');
|
|
|
|
// Detect CI environment
|
|
const isCI = process.env.CI === 'true' ||
|
|
process.env.GITHUB_ACTIONS === 'true' ||
|
|
process.env.CIRCLECI === 'true' ||
|
|
process.env.TRAVIS === 'true' ||
|
|
process.env.BUILDKITE === 'true' ||
|
|
process.env.GITLAB_CI === 'true' ||
|
|
process.env.JENKINS_URL !== undefined;
|
|
|
|
function directoryContainsPatchFiles(directoryPath) {
|
|
try {
|
|
if (!fs.existsSync(directoryPath)) return false;
|
|
const entries = fs.readdirSync(directoryPath);
|
|
for (const entryName of entries) {
|
|
const absoluteEntryPath = path.join(directoryPath, entryName);
|
|
const entryStats = fs.statSync(absoluteEntryPath);
|
|
if (entryStats.isDirectory()) {
|
|
if (directoryContainsPatchFiles(absoluteEntryPath)) return true;
|
|
} else if (entryName.endsWith('.patch')) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
function isExecutableAvailableOnPath(executableName) {
|
|
// Try multiple methods to check if executable is available
|
|
const commands = process.platform === 'win32'
|
|
? ['where', 'where.exe']
|
|
: ['command -v', 'which', '/usr/bin/which'];
|
|
|
|
for (const command of commands) {
|
|
try {
|
|
const whichResult = spawnSync(command, [executableName], {
|
|
shell: true,
|
|
stdio: 'ignore',
|
|
timeout: 5000 // 5 second timeout
|
|
});
|
|
if (whichResult.status === 0) {
|
|
return true;
|
|
}
|
|
} catch (error) {
|
|
// Continue to next command
|
|
continue;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
// Early exit conditions
|
|
if (!fs.existsSync(patchesDirectoryPath)) {
|
|
if (isCI) {
|
|
console.log('patch-package: patches directory not found, skipping (CI mode)');
|
|
} else {
|
|
console.log('patch-package: patches directory not found, skipping');
|
|
}
|
|
process.exit(0);
|
|
}
|
|
|
|
if (!directoryContainsPatchFiles(patchesDirectoryPath)) {
|
|
if (isCI) {
|
|
console.log('patch-package: no patches found, skipping (CI mode)');
|
|
} else {
|
|
console.log('patch-package: no patches found, skipping');
|
|
}
|
|
process.exit(0);
|
|
}
|
|
|
|
// Check if patch-package is available
|
|
if (!isExecutableAvailableOnPath('patch-package')) {
|
|
if (isCI) {
|
|
console.log('patch-package not installed, skipping (CI mode)');
|
|
} else {
|
|
console.log('patch-package not installed, skipping');
|
|
}
|
|
process.exit(0);
|
|
}
|
|
|
|
// Workspaces with isolated node_modules due to nmHoistingLimits: workspaces
|
|
// Most packages are in workspace node_modules, not root
|
|
const workspaceRoots = [
|
|
{ name: 'app', path: path.join(repositoryRootPath, 'app') },
|
|
{ name: 'contracts', path: path.join(repositoryRootPath, 'contracts') }
|
|
];
|
|
|
|
// Run patch-package with better error handling
|
|
try {
|
|
let anyPatchApplied = false;
|
|
let anyPatchFailed = false;
|
|
|
|
// Try root node_modules first (some packages may be hoisted here)
|
|
const rootNodeModules = path.join(repositoryRootPath, 'node_modules');
|
|
if (fs.existsSync(rootNodeModules)) {
|
|
const rootPatchRun = spawnSync('patch-package', ['--patch-dir', 'patches'], {
|
|
cwd: repositoryRootPath,
|
|
shell: true,
|
|
stdio: 'pipe', // Always capture output to check for real errors vs missing packages
|
|
timeout: 30000
|
|
});
|
|
const output = rootPatchRun.stdout?.toString() || '';
|
|
const stderrOutput = rootPatchRun.stderr?.toString() || '';
|
|
const hasRealError = (output.includes('**ERROR**') && !output.includes('which is not present at')) ||
|
|
(stderrOutput.length > 0 && rootPatchRun.status !== 0);
|
|
|
|
if (rootPatchRun.status === 0) {
|
|
if (!isCI) console.log('✓ Patches applied to root workspace');
|
|
anyPatchApplied = true;
|
|
} else if (hasRealError) {
|
|
console.error(`patch-package failed for root workspace`);
|
|
console.error(output);
|
|
if (stderrOutput) console.error(stderrOutput);
|
|
anyPatchFailed = true;
|
|
}
|
|
// If packages are just missing (not hoisted to root), that's expected - continue to workspace patches
|
|
}
|
|
|
|
// Apply patches to workspace node_modules (where most packages are with nmHoistingLimits)
|
|
for (const workspace of workspaceRoots) {
|
|
const workspaceNodeModules = path.join(workspace.path, 'node_modules');
|
|
if (!fs.existsSync(workspaceNodeModules)) continue;
|
|
|
|
const workspacePatchRun = spawnSync('patch-package', ['--patch-dir', '../patches'], {
|
|
cwd: workspace.path,
|
|
shell: true,
|
|
stdio: 'pipe',
|
|
timeout: 30000
|
|
});
|
|
|
|
const output = workspacePatchRun.stdout?.toString() || '';
|
|
const stderrOutput = workspacePatchRun.stderr?.toString() || '';
|
|
const hasRealError = (output.includes('**ERROR**') && !output.includes('which is not present at')) ||
|
|
(stderrOutput.length > 0 && workspacePatchRun.status !== 0);
|
|
|
|
if (workspacePatchRun.status === 0) {
|
|
if (!isCI) console.log(`✓ Patches applied to ${workspace.name} workspace`);
|
|
anyPatchApplied = true;
|
|
} else if (hasRealError) {
|
|
console.error(`patch-package failed for ${workspace.name} workspace`);
|
|
console.error(output);
|
|
if (stderrOutput) console.error(stderrOutput);
|
|
anyPatchFailed = true;
|
|
}
|
|
}
|
|
|
|
if (anyPatchFailed && !isCI) {
|
|
console.error('Some patches failed to apply. Check if patch versions match installed package versions.');
|
|
process.exit(1);
|
|
}
|
|
if (anyPatchFailed && isCI) {
|
|
console.warn('⚠️ CI Warning: Some patches failed to apply. Review patch compatibility.');
|
|
}
|
|
|
|
if (anyPatchApplied) {
|
|
if (!isCI) console.log('✓ patch-package completed');
|
|
else console.log('patch-package completed');
|
|
} else {
|
|
if (!isCI) console.log('patch-package: no patches applied (packages may be in different locations)');
|
|
else console.log('patch-package: no patches applied');
|
|
}
|
|
} catch (error) {
|
|
if (isCI) {
|
|
console.log('patch-package: error during execution (CI mode):', error.message);
|
|
console.log('Continuing build despite patch errors...');
|
|
process.exit(0);
|
|
} else {
|
|
console.error('patch-package error:', error.message);
|
|
process.exit(1);
|
|
}
|
|
}
|
|
|
|
process.exit(0);
|